Repository navigation
GIT_DIR is not respected #58
Description
The way git-up tries to get the path to the repository is not working when the GIT_WORK_TREE and GIT_DIR are different.
get_git_dir() tries to get the repository with
return execute(['git', 'rev-parse', '--show-toplevel'])
As far as I understand --git-dir should be used.
Activity
astitcher commentedon Nov 28, 2016
I'm assuming this issue is raised because git up doesn't work correctly if you are working in a work tree created by
git worktree ....In this case I'm not sure if the correct way to get the repository is
--git-diror--git-common-dir.From a little experimentation
--git-dirgives a location deep inside the repository whereas--git-common-dirgives the actual repository root.kwbr commentedon Nov 29, 2016
You are correct. I use vcsh (https://github.com/RichiH/vcsh) which separates the worktree from the git-dir. After reading the documentation --git-common-dir seem to be the correct way
msiemens commentedon Nov 29, 2016
Thanks for the bug report and the details everyone! I've implemented a fix, but it seems like the git version on Travis doesn't support git's worktree. @kwbr Could you install the latest dev version (should work using
pip install https://github.com/msiemens/PyGitUp) and report if it's actually fixed?kwbr commentedon Nov 30, 2016
Seems to work now. 👍
Installed it with
pip install git+https://github.com/msiemens/PyGitUp.msiemens commentedon Nov 30, 2016
Awesome! Version 1.4.4 has been released now :)
Fix running PyGitUp from a subdirectory
Detect root git dir when using worktree