Repository navigation
fix(nodes): stage dedicated diarization audio - #12474
Merged
Merged
Conversation
Dedicated diarization forwards frontend audio paths to remote workers, which cannot read those temporary files. Stage the input before the RPC and release it afterward, following the transcription lifecycle. Clone the request so staging does not change caller-owned data. Cover input bytes, request fields, cleanup, and error propagation in tests. Document distributed diarization staging on the existing feature page. Assisted-by: nib:gpt-6-astra Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix distributed
/v1/audio/diarizationrequests that send a frontend-only temporary audio path to a remote worker. The worker cannot open that path and fails before inference.Add a
FileStagingClient.Diarizeoverride using the existing transcription staging lifecycle. Clone the request, transfer its input, forward the worker-local path, and release the staged input afterward.No linked issue.
Notes for Reviewers
Regression tests cover exact input bytes, remote path substitution, request immutability, context/options forwarding, and cleanup on success and errors. The three new specs fail before the fix and pass afterward.
Verification:
go test -p 2 ./core/services/nodes -count=1β passed.go test ./core/services/nodes -count=1 -v -ginkgo.focus='[Ss]taging|FileStagingClient' -timeout=180sβ independently verified, 57 specs passed.golangci-lint run ./core/services/nodes/...β passed.git diff --checkand Go formatting checks β passed.The full build and live deployment of this fix were not run. Repository-wide lint timed out; scoped lint passed. No protobuf or backend-model changes are required.
Signed commits
docs/content/features/audio-diarization.md).