Skip to content

fix(nodes): stage dedicated diarization audio - #12474

Merged
mudler merged 1 commit into
masterfrom
fix/diarization-file-staging
Oct 4, 2026
Merged

mudler merged 1 commit into
masterfrom
fix/diarization-file-staging

Conversation

@mudler-agent

Copy link
Copy Markdown
Collaborator

Description

Fix distributed /v1/audio/diarization requests that send a frontend-only temporary audio path to a remote worker. The worker cannot open that path and fails before inference.

Add a FileStagingClient.Diarize override using the existing transcription staging lifecycle. Clone the request, transfer its input, forward the worker-local path, and release the staged input afterward.

No linked issue.

Notes for Reviewers

Regression tests cover exact input bytes, remote path substitution, request immutability, context/options forwarding, and cleanup on success and errors. The three new specs fail before the fix and pass afterward.

Verification:

  • go test -p 2 ./core/services/nodes -count=1 β€” passed.
  • go test ./core/services/nodes -count=1 -v -ginkgo.focus='[Ss]taging|FileStagingClient' -timeout=180s β€” independently verified, 57 specs passed.
  • golangci-lint run ./core/services/nodes/... β€” passed.
  • git diff --check and Go formatting checks β€” passed.

The full build and live deployment of this fix were not run. Repository-wide lint timed out; scoped lint passed. No protobuf or backend-model changes are required.

Signed commits

  • Yes, I signed my commits (DCO sign-off).
  • Documentation updated (docs/content/features/audio-diarization.md).

Dedicated diarization forwards frontend audio paths to remote workers,
which cannot read those temporary files. Stage the input before the RPC
and release it afterward, following the transcription lifecycle.

Clone the request so staging does not change caller-owned data. Cover
input bytes, request fields, cleanup, and error propagation in tests.
Document distributed diarization staging on the existing feature page.

Assisted-by: nib:gpt-6-astra
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler
mudler merged commit d3724ee into master Oct 4, 2026
71 checks passed
@mudler
mudler deleted the fix/diarization-file-staging branch October 4, 2026 11:14
@mudler-agent mudler-agent added the bug Something isn't working label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants