Skip to content

chore: bump base58 version - #67

Merged
lidel merged 2 commits into
multiformats:masterfrom
mr-tron:master
Apr 7, 2026
Merged

lidel merged 2 commits into
multiformats:masterfrom
mr-tron:master

Conversation

@mr-tron

@mr-tron mr-tron commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

https://github.com/mr-tron/base58/releases/tag/v1.3.0 - new release with improved performance

@lidel lidel changed the title bump base58 version chore: bump base58 version Apr 7, 2026
The base58/base58 sub-package was deprecated in v1.3.0,
with all optimized code living in the root package.

- multibase.go: import github.com/mr-tron/base58 directly
- go.sum: remove stale v1.1.0 checksums via go mod tidy

@lidel lidel left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump! The v1.3.0 rewrite looks solid.

One thing: go-multibase imports the deprecated base58/base58 sub-package. In v1.3.0 that's just a wrapper, so we'd get deprecation warnings without the actual performance gains?

iiuc the root package has the same API, so i applies the fix:

-     b58 "github.com/mr-tron/base58/base58"
+     b58 "github.com/mr-tron/base58"

Plus a go mod tidy to clean up stale checksums. I'll merge and release as soon tests pass.

@lidel
lidel merged commit 4cceaac into multiformats:master Apr 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants