Repository navigation
chore: bump base58 version - #67
Merged
Merged
Conversation
The base58/base58 sub-package was deprecated in v1.3.0, with all optimized code living in the root package. - multibase.go: import github.com/mr-tron/base58 directly - go.sum: remove stale v1.1.0 checksums via go mod tidy
lidel
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Thanks for the bump! The v1.3.0 rewrite looks solid.
One thing: go-multibase imports the deprecated base58/base58 sub-package. In v1.3.0 that's just a wrapper, so we'd get deprecation warnings without the actual performance gains?
iiuc the root package has the same API, so i applies the fix:
- b58 "github.com/mr-tron/base58/base58"
+ b58 "github.com/mr-tron/base58"Plus a go mod tidy to clean up stale checksums. I'll merge and release as soon tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/mr-tron/base58/releases/tag/v1.3.0 - new release with improved performance