Repository navigation
fix(cli): count structured non-zero outcomes and skip account-disabled features in live dogfood - #5354
Merged
mergify[bot] merged 2 commits intoNov 6, 2026
Conversation
(cherry picked from commit fe403dec10e3b4acd7d519b3c1209737911b09e9)
Contributor
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 require-ready-label-and-ci
🟢 🚦 Auto-queueWhen all merge protections are satisfied and these conditions match, this pull request will be queued automatically.
|
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issue was found. SummaryThe PR counts declared nonzero exits when they return a structured result and skips explicit account-disabled HTTP 403/404 responses.
|
… judge large verdicts on full output
56 of 96 tasks
Contributor
✅ Merged into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5351.
Live dogfood had two blind spots. A command whose contract is "exit non-zero with a structured verdict" (a go/no-go check that exits 2 on NO-GO) was always skipped, so the feature stayed hollow even though it returned a real result. And endpoints for a feature switched off in the account (403/404 "... is not enabled for this ...") were reported as failures, which pushed operators toward hand-editing rows.
Changes
liveDogfoodStructuredOutcome: a declared non-zero exit counts as a happy-path and JSON pass only when stdout is a non-empty JSON object (orresultsobject) with noerrorand nosuccess: false. Usage errors and silent exits still don't count.live_dogfood_outcome_test.gocovers NO-GO verdicts at the top level and underresults, error envelopes in both places, a full run that counts a declared NO-GO exit, disabled-feature 403 and 404 bodies, and the cases that must stay failures: a plain 404, a 500 with the same message, the message without an HTTP status, and exit 0.Verification
go build ./...,go vet ./internal/...pass.go test ./internal/pipeline: all pass exceptTestSnapshotLiveCheckBinaryStagesBesideSymlinkTarget, which fails the same way onmainat 26d1e3f (macOS/varvs/private/var).foundinggo/no-go command).