Repository navigation
fix(core): reset the listening state when the application closes - #17951
Merged
kamilmysliwiec merged 2 commits intoSep 30, 2026
Merged
Conversation
`listen()` sets `isListening` and `HttpAdapterHost.listening` to true, but closing the application never reset them. After `app.close()`, `HttpAdapterHost.listening` still reported true, and `app.getUrl()` skipped its "call listen first" guard and rejected with `TypeError: Cannot read properties of null (reading 'port')`. Reset both flags once the HTTP adapter has closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NestApplication.listen()setsisListeningandHttpAdapterHost.listeningtotrue, butdispose()never sets them back. Afterclose(),HttpAdapterHost.listening, documented as whether the application is listening for incoming requests, still reportstrue.getUrl()passes itsCALL_LISTEN_FIRSTguard becauseisListeningis still set, reads the closed server'saddress()(null) and fails with aTypeError. This shows up in tests or tools that stop and restart apps, and in code that checkslistening.The new spec against the current
nest-application.ts:Issue Number: N/A
What is the new behavior?
dispose()setsisListeningandHttpAdapterHost.listeningtofalseright after the HTTP adapter closes, so afterclose()the flag reportsfalseandgetUrl()rejects withapp.listen() needs to be called before calling app.getUrl().listen$only emits when the flag becomestrue, so it does not emit or complete on close. If the adapter'sclose()throws, the flags stay as they were, since the server may still be running.The new test listens on a random local port and closes the app. A throwaway spec with the real Express and Fastify adapters showed the same result on both.
Does this PR introduce a breaking change?
Other information
npx vitest run packages/core: 1400 passed.