Repository navigation
fix(core): preserve explicit null values in reflectable decorators - #17978
Merged
Merged
Conversation
Signed-off-by: gophersg <gopher@2980.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Reflector.createDecorator<TParam>()internally stores metadata values usingvalue ?? {}.Because
nullis coalesced to{}, an explicit@Decorator(null)does not preserve the intendednullvalue. The reflected result contradicts the decorator's TypeScript type contract.Example:
The same issue affects
transformfunctions that intentionally returnnull.Issue Number: N/A
What is the new behavior?
Only a genuinely missing value (
undefined) falls back to the empty-object marker used by argument-less decorators. An explicitnull(or a transform result ofnull) is now preserved unchanged.This is consistent with how
getAllAndOverridealready treats metadata — it skipsundefinedbut keepsnullas a legitimate value.Does this PR introduce a breaking change?
The fallback to
{}is only relevant for decorators called without arguments (e.g.@Decorator()). All existing non-null usages continue to behave identically.Other information
nullmetadata valuetransformreturningnull{}0,'',false) remain unchanged