Repository navigation
fix(microservices): suspend incomplete packet timers during backpressure - #17989
Merged
kamilmysliwiec merged 1 commit intoOct 2, 2026
Merged
Conversation
4 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Outgoing backpressure pauses inbound processing, leaving complete received frames buffered. The incomplete-packet timer treats that buffer as a stalled partial packet and destroys the connection. A timer armed before reads are paused has the same problem.
What is the new behavior?
Suspend incomplete-packet timers while reads are paused for outgoing backpressure. Rearm after drain only if a partial packet remains. Regressions verify complete buffered frames survive a prolonged pause, and a genuinely partial packet still times out after drain.
Does this PR introduce a breaking change?
No.
Validation
npx vitest run packages/microservices/test/helpers/json-socket.spec.ts: 21 tests passed.npm run build: passed.npm run lintandgit diff --check: passed, with the existing optional-chain warning insocket-module.ts.This branch contains one independent change based on
7fb52e7f4f7314fbc117e369a09297bc2ecadf6b.