Repository navigation
fix(microservices): close both kafka client connections when one fails - #18027
Merged
kamilmysliwiec merged 2 commits intoOct 8, 2026
Merged
kamilmysliwiec merged 2 commits into
kamilmysliwiec merged 2 commits into
Conversation
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ClientKafka.close()disconnects the producer and then the consumer. If theproducer's
disconnect()rejects, the consumer is never disconnected and thecached state (
initialized,client, ...) is never reset.Issue Number: N/A
What is the new behavior?
Both clients are disconnected with
Promise.allSettled, and the state isreset in a
finallyblock.close()still rejects with the error, so thecaller still sees the failure.
Does this PR introduce a breaking change?
Other information
This is the client part of #17990, split out after review. The server side
is left as is since its consumer-first order is needed for graceful shutdown.