Repository navigation
fix(core): discover classes by each of their discovery decorators - #18235
Merged
kamilmysliwiec merged 1 commit intoOct 22, 2026
Merged
kamilmysliwiec merged 1 commit into
kamilmysliwiec merged 1 commit into
Conversation
A class with two decorators created by DiscoveryService.createDecorator() was only discovered by the one applied last. Keep every key per class.
4 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
DiscoverableMetaHostCollectionlinks each class to a single metadata key (discoverable-meta-host-collection.ts#L38). When a class has two decorators created withDiscoveryService.createDecorator(), the one applied last replaces the other, andgetProviders({ metadataKey })andgetControllers({ metadataKey })don't return the class for the other decorator.getMetadataByDecorator()still finds its metadata.With the repro on 12.2.0:
Same on 10.4.15 and 11.1.6.
What is the new behavior?
A class keeps every key and is registered under each of them. With the repro, both decorators return
["CleanupService","ReportService"]and["AdminController"].Tests: the unit test that expected the second key to replace the first now expects both keys. New tests for
inspectProvider()and indiscovery-service.spec.ts(class, factory, value and alias providers, and a controller) fail without the change.Does this PR introduce a breaking change?
Other information
DiscoverableMetaHostCollection.metaHostLinksnow maps a class to aSetof keys instead of a single key.