Skip to content

affected: all workspace projects are run when touching workspace.jsonย #3033

Closed

Description

@Hotell

Expected Behavior

nothing is being executed when touching files not defined within implicitDependencies

Current Behavior

nx.json

{
  "npmScope": "myproject",
  "implicitDependencies": {
    "package.json": {
      "dependencies": "*",
      "devDependencies": "*"
    },
    "tsconfig.json": "*",
    ".eslintrc.js": "*"
  }

If I generate new lib or manually touch workspace.json or nx.json all projects within workspace are run when executing affected

  • Is workspace.json and nx.json now set as default implicitDep no matter what?
    • this is too bad as on every new lib/app generation, CI will have hard time :)

Context

  @nrwl/angular : Not Found
  @nrwl/cli : 9.3.0
  @nrwl/cypress : 9.3.0
  @nrwl/eslint-plugin-nx : 9.3.0
  @nrwl/express : Not Found
  @nrwl/jest : 9.3.0
  @nrwl/linter : 9.3.0
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : 9.3.0
  @nrwl/react : 9.3.0
  @nrwl/schematics : Not Found
  @nrwl/tao : 9.3.0
  @nrwl/web : 9.3.0
  @nrwl/workspace : 9.3.0
  typescript : 3.8.3

Activity

  1. changed the title [-]affected: all pipeline are run when touching workspace.json[/-] [+]affected: all workspace projects are run when touching workspace.json[/+] on May 19, 2020
  2. FrozenPandaz commented on May 21, 2020

    @FrozenPandaz
    Contributor

    You can opt into more intelligent processing of changes to workspace.json and nx.json by removing theimplicitDependencies as you did.

    If you generate a new lib, it should only affect the new generated lib. If you touch a field that's outside of projects though, it will affect everything. Such as removing the implicitDependencies from nx.json. You should commit those changes first. I got caught by this many times too. ๐Ÿ˜‰

    @Hotell let me know if this fulfills your expected behavior.

  3. github-actions commented on Nov 6, 2020

    @github-actions
    Contributor

    This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
    If we missed this issue please reply to keep it active.
    Thanks for being a part of the Nx community! ๐Ÿ™

  4. github-actions commented on Mar 24, 2023

    @github-actions
    Contributor

    This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

  5. locked as resolved and limited conversation to collaborators on Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions