Repository navigation
[pkg/xreceiverhelper] Report profile sample metrics per sample type - #16251
Merged
codeboten merged 16 commits intoNov 6, 2026
Merged
Conversation
Add ObsReport.EndProfilesOpBySampleType and ProfileSampleCountsByType so
otelcol_receiver_{accepted,refused,failed}_profile_samples can carry a
sample_type attribute. Use it in the OTLP receiver.
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16251 +/- ##
==========================================
+ Coverage 91.35% 91.37% +0.01%
==========================================
Files 760 762 +2
Lines 50704 50772 +68
==========================================
+ Hits 46322 46394 +72
+ Misses 3031 3029 -2
+ Partials 1351 1349 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
songy23
reviewed
Oct 28, 2026
…ndices Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
dmathieu
reviewed
Oct 29, 2026
…receiverhelper Profiles are not a stable signal, so the new EndProfilesOpBySampleType and ProfileSampleCountsByType APIs live in a new xreceiverhelper module instead of receiverhelper. The signal-agnostic parts of endOp move to receiverhelper's internal package so both modules share them. Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
florianl
commented
Oct 30, 2026
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
…eiver Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
dmathieu
approved these changes
Oct 30, 2026
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Member
|
Could you fix the PR title? This is now in xreceiverhelper. |
Signed-off-by: Florian Lehner <florian.lehner@datadoghq.com>
codeboten
reviewed
Nov 5, 2026
codeboten
left a comment
Member
There was a problem hiding this comment.
One more merge conflict to resolve
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
should be good to merge |
codeboten
approved these changes
Nov 6, 2026
Merged
via the queue into
open-telemetry:main
with commit Nov 6, 2026
9b35cca
121 of 126 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ObsReport.EndProfilesOpBySampleTypeandProfileSampleCountsByTypesootelcol_receiver_{accepted,refused,failed}_profile_samplescan carry asample_typeattribute. Use it in the OTLP receiver.A single OTLP profiles payload can hold several profiles with different sample types, e.g. CPU samples, off-CPU time and allocations. A plain sample count adds all of them together. It can't show which kind of profile data was accepted or lost, and it mixes samples whose values mean different things (e.g. "samples:count" vs "off_cpu:nanoseconds"). Tagging the counters with the sample type, as "type:unit", shows which profile types were affected by refused or failed requests. It also shows how much of each type the receiver ingests.
Link to tracking issue
Fixes #
Testing
Documentation
Authorship