Skip to content

Gracefully handle FixedSizeReservoir of size 0 #8232

Closed

Description

@dashpole

Description

I don't believe this is possible if using the reservoir through the SDK, but the current reservoir can panic if the size of the reservoir is 0.

Found by Copilot in #8230 (comment)

Expected behavior

The reservoir should not panic even if the size is 0.

Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Activity

  1. added a commit that references this issue on Apr 21, 2026
    e02b0c1
  2. muskiteer commented on May 1, 2026

    @muskiteer
    Contributor

    hi, I would like to take on this issue. Can you assign it to me please.

  3. muskiteer commented on May 7, 2026

    @muskiteer
    Contributor

    I have completed the fix in the pr #8295. merging is still pending for that.

  4. added a commit that references this issue on May 22, 2026
    a51ddb1
  5. added this to the v1.44.0 milestone on May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions