Skip to content

Bump golang.org/x/tools from 0.3.0 to 0.4.0 in /internal/tools - #3535

Merged
MrAlias merged 1 commit into
mainfrom
dependabot/go_modules/internal/tools/golang.org/x/tools-0.4.0
Dec 15, 2022
Merged

MrAlias merged 1 commit into
mainfrom
dependabot/go_modules/internal/tools/golang.org/x/tools-0.4.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Dec 11, 2022 •

Copy link
Copy Markdown
Contributor

Bumps golang.org/x/tools from 0.3.0 to 0.4.0.

Release notes

Sourced from golang.org/x/tools's releases.

gopls/v0.4.0

  • Improved support for working with modules (@​ridersofrohan). A detailed walk-through of the new features can be found here. A quick summary:
    • Use the -modfile flag to suggest which modules should be added/removed from the go.mod file, rather than editing it automatically.
    • Suggest dependency upgrades in-editor and provide additional language features, such as formatting, for the go.mod file.
  • Inverse implementations (@​muirdm). "Go to implementations" on a concrete type will show the interfaces it implements.
  • Completion improvements (@​muirdm). Specifically, improved completion for keywords. Also, offer if err != nil { return err } as a completion item.
  • Jumping to definition on an import statement returns all files as definition locations (@​danishprakash).
  • Support for running go generate through the editor, via a code lens (@​marwan-at-work).
  • Command-line support for workspace symbols (@​daisuzu).

Opt-in:

  • Code actions suggesting gofmt -s-style simplifications (@​ridersofrohan). To get these on-save, add the following setting:
"[go]": {
	"editor.codeActionsOnSave": {
		"source.fixAll": true,
	}
}
  • Code actions suggesting fixes for type errors, such as missing return values (goreturns-style), undeclared names, unused parameters, and assignment statements that should be converted from := to = (@​ridersofrohan). Add the following to your gopls settings to opt-in to these analyzers. In the future, they will be on by default and high-confidence suggested fixes may be applied on save. See additional documentation on analyzers here.
"gopls": {
	"analyses": {
		"fillreturns": true,
                "undeclaredname": true,
                "unusedparams": true,
                "nonewvars": true,
	}
}
  • Further improvements in the support for multiple concurrent clients (@​findleyr). See #34111 for all details.

For a complete list of the issues resolved, see the gopls/v0.4.0 milestone.

gopls/v0.3.4

gopls/v0.3.3

  • Support for workspace symbols. (@​daisuzu)
  • Various completion improvements, including fixes for completion in code that doesn't parse. (@​muirdm)
  • Limit diagnostic concurrency, preventing huge spikes in memory usage that some users encountered. (@​heschik)
  • Improved handling for URIs containing escaped characters. (@​heschik)
  • Module versions from "go list" in pkg.go.dev links. (@​ridersofrohan)

... (truncated)

Commits
  • aee3994 gopls/internal/lsp/fake: in (*Workdir).RenameFile, fall back to read + write
  • fe60148 go.mod: update golang.org/x dependencies
  • c9ea9a7 gopls/internal/regtest: add a test for the case when the renaming package's p...
  • bf5db81 gopls/internal/lsp/cache: improve ad-hoc warning for nested modules
  • aa9f4b2 go/analysis: document that facts are gob encoded in one gulp
  • bdcd082 internal/gcimporter: skip tests earlier when 'go build' is not available
  • 2ad6325 gopls/internal/lsp/cache: expand ImportPath!=PackagePath comment
  • 52c7b88 gopls/internal/robustio: only define ERROR_SHARING_VIOLATION on Windows
  • 4f69bf3 gopls/internal/lsp/cache: narrow reloadOrphanedFiles to open files
  • 6002d6e gopls/internal/regtest/misc: test Implementations + vendor
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog PRs that do not require a CHANGELOG.md entry labels Dec 11, 2022
@codecov

codecov Bot commented Dec 11, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3535 (6eff6ab) into main (4e76347) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3535     +/-   ##
=======================================
+ Coverage   77.9%   78.0%   +0.1%     
=======================================
  Files        164     164             
  Lines      11703   11762     +59     
=======================================
+ Hits        9123    9182     +59     
  Misses      2385    2385             
  Partials     195     195             
Impacted Files Coverage Δ
sdk/metric/reader.go 100.0% <ø> (ø)
sdk/metric/config.go 94.5% <100.0%> (+0.2%) ⬆️
sdk/metric/manual_reader.go 84.6% <100.0%> (+5.9%) ⬆️
sdk/metric/periodic_reader.go 91.3% <100.0%> (+1.8%) ⬆️

@MrAlias

MrAlias commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

@dependabot rebase

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/go_modules/internal/tools/golang.org/x/tools-0.4.0 branch from b4602a8 to 6eff6ab Compare December 15, 2022 15:55
@MrAlias
MrAlias merged commit 7a60bc7 into main Dec 15, 2022
@MrAlias
MrAlias deleted the dependabot/go_modules/internal/tools/golang.org/x/tools-0.4.0 branch December 15, 2022 20:49
@MrAlias MrAlias added this to the Release v1.12.0 milestone Jan 27, 2023
dashpole added a commit that referenced this pull request May 14, 2026
Fix #8299

Relevant upstream v1.41.0 release notes:

> ### 🛑 Breaking changes 🛑
> 
> - `graphql`: Change `graphql.document` attribute requirement level
from Recommended to Opt-In due to sensitive data, cardinality, and size
concerns
([#2985](open-telemetry/semantic-conventions#2985))
> - `process`: Move process.executable to its own entity.
([#3535](open-telemetry/semantic-conventions#3535))
> - `process`: Update requirement levels for process attributes to
ensure consistent identification and description across platforms.
([#864](open-telemetry/semantic-conventions#864))
> - `rpc`: Remove `client.address` and `client.port` attributes from RPC
server spans.
([#3487](open-telemetry/semantic-conventions#3487),
[#3488](open-telemetry/semantic-conventions#3488))
> 
> ### 💡 Enhancements 💡
> 
> - `Go`: Add opt-in go.memory.gc.pause.duration histogram metric.
([#3353](open-telemetry/semantic-conventions#3353))
> - `deployment`: Stabilize `deployment.environment.name` attribute.
([#3339](open-telemetry/semantic-conventions#3339))
> - `deployment`: Add enum values for `deployment.environment.name`
attribute.
([#2910](open-telemetry/semantic-conventions#2910))
> - `go`: Add the go.cpu.time opt-in metric, and add
go.cpu.detailed_state and go.memory.detailed_type attributes to CPU and
memory metrics respectively with wildcard values.
([#3354](open-telemetry/semantic-conventions#3354))
> - `go`: Add the opt-in go.memory.gc.cycles metric.
([#3353](open-telemetry/semantic-conventions#3353))
> - `telemetry`: Promote `telemetry.distro.name` and
`telemetry.distro.version` attributes to 'stable'.
([#3650](open-telemetry/semantic-conventions#3650))

This PR also:
- fixes semconv migration generation to ignore unexported declarations
when computing renames/removals
- upgrades repo imports, depguard, docs, templates, and schema URL
expectations to `go.opentelemetry.io/otel/semconv/v1.41.0`
- adds missing generated-file headers to semconvkit templates and
regenerates the affected `v1.41.0` files via `TAG="v1.41.0" make
semconv-generate`

---------

Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant