Repository navigation
Test OTLP retry cancellation causes - #8724
Merged
dashpole merged 5 commits intoAug 18, 2026
Merged
Conversation
Add a TestWait case that cancels a context with a custom cause and asserts the retry wait returns that cause. Regenerate all OTLP exporter copies so the behavior is covered consistently. This follows up on review feedback from open-telemetry#7811, which changed retry cancellation handling to preserve context causes.
Codecov Reportโ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8724 +/- ##
=====================================
Coverage 84.1% 84.1%
=====================================
Files 331 331
Lines 26487 26487
=====================================
+ Hits 22286 22296 +10
+ Misses 3795 3786 -9
+ Partials 406 405 -1 ๐ New features to boost your workflow:
|
MrAlias
marked this pull request as ready for review
August 10, 2026 20:26
MrAlias
requested review from
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 10, 2026 20:26
ps-mir
reviewed
Aug 11, 2026
ps-mir
left a comment
Member
There was a problem hiding this comment.
Thoughts on test for RequestFunc ?
Exercise both default and custom cancellation causes through the retry request wrapper. This proves the wrapper preserves the caller-provided cause alongside the request error without making an extra request. Regenerate all OTLP retry test copies from the shared template.
Contributor
Author
|
@ps-mir Added |
ps-mir
approved these changes
Aug 12, 2026
pellared
approved these changes
Aug 17, 2026
dashpole
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestWaittableThis follows up on review feedback from #7811. The existing test covered the default
context.Canceledresult but did not exercise a caller-supplied cancellation cause. The new case pins that behavior across every generated retry package.This is test-only and does not change runtime behavior.
Testing
make precommit