Repository navigation
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 25, 2026 05:18
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8862 +/- ##
=======================================
- Coverage 88.6% 88.6% -0.1%
=======================================
Files 333 333
Lines 21289 21297 +8
=======================================
+ Hits 18873 18880 +7
- Misses 2416 2417 +1
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Aug 25, 2026
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Contributor
Author
|
Resolved the merge conflict. |
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
…env-endpoint-path Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com> # Conflicts: # CHANGELOG.md
dmathieu
reviewed
Sep 9, 2026
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
dmathieu
approved these changes
Sep 10, 2026
pellared
added a commit
that referenced
this pull request
Oct 2, 2026
This release contains the first stable release of the OpenTelemetry Go Logs API and SDK. Our project stability guarantees now apply to the following modules: - `go.opentelemetry.io/otel/log` - `go.opentelemetry.io/otel/sdk/log` See our [versioning policy](https://github.com/open-telemetry/opentelemetry-go/blob/main/VERSIONING.md) for more information about these stability guarantees. ### Added - Add `String` method for `KeyValue` type in `go.opentelemetry.io/otel/attribute`. (#8205) - Add `String` method for `Set` type in `go.opentelemetry.io/otel/attribute`. (#8347) - Add `WithMaxExportBatchSize` to `go.opentelemetry.io/otel/sdk/metric` to configure the maximum export batch size for `PeriodicReader`. (#8960) - Add `WithAttributeValueDepthLimit`, `DefaultAttributeValueDepthLimit`, and `SpanLimits.AttributeValueDepthLimit` in `go.opentelemetry.io/otel/sdk/trace` to configure the maximum depth of span, event, link, and instrumentation scope attribute values. (#8938) - Add `WithAttributeValueDepthLimit` in `go.opentelemetry.io/otel/sdk/log` to configure the maximum depth of log record and instrumentation scope attribute values. (#8938) - Add `WithMaxResponseSize` to `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`, `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`, and `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8941) - Add experimental `ProbabilitySampler` in `go.opentelemetry.io/otel/sdk/trace/x` that conforms to the [OpenTelemetry specification's threshold-based sampling algorithm](https://opentelemetry.io/docs/specs/otel/trace/sdk/#probabilitysampler). (#8123) - Add experimental `*Binder` extension interfaces in `go.opentelemetry.io/otel/metric/x` for instruments that support binding attributes ahead of time. (#8760) - Add the experimental `Finisher` synchronous metric instrument extension interface to `go.opentelemetry.io/otel/metric/x`. (#8906) ### Changed - Use the [OpenTelemetry Attribute Collection representation for non-OTLP protocols](https://opentelemetry.io/docs/specs/otel/common/#attribute-collection-representation-for-non-otlp) for metric data diffs in `go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest`. (#8993) - Apply a maximum depth of 64 by default to span, event, link, log record, and instrumentation scope attribute values in `go.opentelemetry.io/otel/sdk/trace` and `go.opentelemetry.io/otel/sdk/log`. (#8938) - Reduce allocations when applying attribute value length limits in `go.opentelemetry.io/otel/sdk/trace` and `go.opentelemetry.io/otel/sdk/log` by rebuilding composite values only when truncation is needed. (#8912) - Decode `traceparent` using a hex lookup table in `go.opentelemetry.io/otel/propagation`, which rejects the specification-disallowed upper-case characters without a separate scan of the header. (#8739) - Decode all characters at constant indices in `TraceIDFromHex` and `SpanIDFromHex` in `go.opentelemetry.io/otel/trace` to eliminate bounds checks. (#8740) ### Fixed - Count valid U+FFFD replacement characters toward attribute value length limits in `go.opentelemetry.io/otel/trace`, `go.opentelemetry.io/otel/sdk/trace`, and `go.opentelemetry.io/otel/sdk/log`. - Truncate string attribute values to empty strings when the configured length limit is zero, including malformed UTF-8, in `go.opentelemetry.io/otel/trace`, `go.opentelemetry.io/otel/sdk/trace`, and `go.opentelemetry.io/otel/sdk/log`. (#9054) - Fix a data race in `NewPeriodicReader` where `r.inst` was assigned after the background goroutine was launched in `go.opentelemetry.io/otel/sdk/metric`. (#9028) - Prevent precision loss for large `int64` values in `Sum`, `Histogram`, and `ExponentialHistogram` aggregations in `go.opentelemetry.io/otel/sdk/metric`. (#8981) - Ensure `grpc.DialOption` values passed via `WithDialOption` take precedence over conflicting internally-computed defaults in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`, `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`, and `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#8805, #8834, #8836) - Treat overflowing `OTEL_METRIC_EXPORT_INTERVAL` and `OTEL_METRIC_EXPORT_TIMEOUT` values as invalid in `go.opentelemetry.io/otel/sdk/metric`. (#8800) - Prevent a panic in `NewFixedSizeReservoir` and `FixedSizeReservoirProvider` when given a negative size in `go.opentelemetry.io/otel/sdk/metric/exemplar`; negative sizes are now clamped to zero, consistent with a size of zero. (#8832) - Preserve exponential histogram `ZeroThreshold` during OTLP metric export in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric`. (#8801) - Ensure metric helpers in `go.opentelemetry.io/otel/semconv/v1.32.0`, `go.opentelemetry.io/otel/semconv/v1.33.0`, and `go.opentelemetry.io/otel/semconv/v1.34.0` record measurements only once when no attributes are provided. (#8849) - Treat empty `OTEL_TRACES_SAMPLER` and `OTEL_TRACES_SAMPLER_ARG` values as unset in `go.opentelemetry.io/otel/sdk/trace`. (#8873) - Normalize global `OTEL_EXPORTER_OTLP_ENDPOINT` path joining in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp` so trailing-slash base URLs do not produce double-slash log export paths. (#8864) - Prevent a deadlock when formatting an error passed to `RecordError` calls back into the span in `go.opentelemetry.io/otel/sdk/trace`. (#8815) - Prevent `SimpleSpanProcessor.Shutdown` from panicking when constructed with a nil exporter in `go.opentelemetry.io/otel/sdk/trace`. (#8844) - Propagate invalid exponential histogram scale errors to Prometheus exporter self-observability metrics in `go.opentelemetry.io/otel/exporters/prometheus`. (#8839) - Retain instrument advisory attributes configured with `go.opentelemetry.io/otel/metric/x.WithDefaultAttributes` when a matching View in `go.opentelemetry.io/otel/sdk/metric` does not specify an attribute filter. (#8859) - Ignore HTTP URL paths when building OTLP/gRPC metric exporter targets from `OTEL_EXPORTER_OTLP_ENDPOINT` and `OTEL_EXPORTER_OTLP_METRICS_ENDPOINT`, while preserving `unix://` and `unix-abstract://` targets; treat `unix-abstract://` endpoints as insecure in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc` and `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#8862) - Ignore HTTP(S) paths when deriving gRPC trace exporter endpoints from `OTEL_EXPORTER_OTLP_ENDPOINT` and `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#8852) - Bound memory used while parsing dense W3C property metadata by storing it compactly and materializing `Property` values on demand in `go.opentelemetry.io/otel/baggage` and `go.opentelemetry.io/otel/propagation`. ### Removed - Remove the experimental `OTEL_GO_X_METRIC_EXPORT_BATCH_SIZE` environment variable in `go.opentelemetry.io/otel/sdk/metric`. Use the `WithMaxExportBatchSize` option instead. (#8960)
vignesh2027
added a commit
to vignesh2027/opentelemetry-go
that referenced
this pull request
Oct 22, 2026
withEndpointScheme in the shared trace config template only treated "http" and "unix" as insecure. A unix-abstract:// endpoint set through OTEL_EXPORTER_OTLP_ENDPOINT or OTEL_EXPORTER_OTLP_TRACES_ENDPOINT fell through to WithSecure, so the trace exporter turned TLS on for a local abstract socket. The metric template already handles unix-abstract since open-telemetry#8862. Add unix-abstract to the insecure schemes in the template, regenerate the otlptracegrpc and otlptracehttp copies, and add a test case.
vignesh2027
added a commit
to vignesh2027/opentelemetry-go
that referenced
this pull request
Oct 26, 2026
withEndpointScheme in the shared trace config template only treated "http" and "unix" as insecure. A unix-abstract:// endpoint set through OTEL_EXPORTER_OTLP_ENDPOINT or OTEL_EXPORTER_OTLP_TRACES_ENDPOINT fell through to WithSecure, so the trace exporter turned TLS on for a local abstract socket. The metric template already handles unix-abstract since open-telemetry#8862. Add unix-abstract to the insecure schemes in the template, regenerate the otlptracegrpc and otlptracehttp copies, and add a test case.
vignesh2027
added a commit
to vignesh2027/opentelemetry-go
that referenced
this pull request
Oct 26, 2026
…try#9261) `withEndpointScheme` in `internal/shared/otlp/otlptrace/otlpconfig/envconfig.go.tmpl` treats only `http` and `unix` endpoints as insecure. A `unix-abstract://` endpoint set through `OTEL_EXPORTER_OTLP_ENDPOINT` or `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` falls through to `WithSecure`, so the trace exporter enables TLS for a local abstract socket. The metric template already lists `unix-abstract` (open-telemetry#8862), so the trace and metric exporters behave differently for the same endpoint. This adds `unix-abstract` to the insecure schemes in the trace template and regenerates the `otlptracegrpc` and `otlptracehttp` copies with `go generate`. The only generated changes are the one-line `envconfig.go` change and the new test case in both modules. Testing: Added a "Test Environment Unix Abstract Endpoint" case to the shared trace options test template, mirroring the existing unix case and the metric unix-abstract case. It fails on main in both modules (`Insecure` is false) and passes with the change. `go test -race ./...`, `golangci-lint run`, `go vet` and `gofmt` are clean for `exporters/otlp/otlptrace/otlptracegrpc` and `exporters/otlp/otlptrace/otlptracehttp`. Co-authored-by: Robert Pająk <pellared@hotmail.com>
NUAAwqy
pushed a commit
to NUAAwqy/opentelemetry-go
that referenced
this pull request
Nov 5, 2026
…try#9261) `withEndpointScheme` in `internal/shared/otlp/otlptrace/otlpconfig/envconfig.go.tmpl` treats only `http` and `unix` endpoints as insecure. A `unix-abstract://` endpoint set through `OTEL_EXPORTER_OTLP_ENDPOINT` or `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` falls through to `WithSecure`, so the trace exporter enables TLS for a local abstract socket. The metric template already lists `unix-abstract` (open-telemetry#8862), so the trace and metric exporters behave differently for the same endpoint. This adds `unix-abstract` to the insecure schemes in the trace template and regenerates the `otlptracegrpc` and `otlptracehttp` copies with `go generate`. The only generated changes are the one-line `envconfig.go` change and the new test case in both modules. Testing: Added a "Test Environment Unix Abstract Endpoint" case to the shared trace options test template, mirroring the existing unix case and the metric unix-abstract case. It fails on main in both modules (`Insecure` is false) and passes with the change. `go test -race ./...`, `golangci-lint run`, `go vet` and `gofmt` are clean for `exporters/otlp/otlptrace/otlptracegrpc` and `exporters/otlp/otlptrace/otlptracehttp`. Co-authored-by: Robert Pająk <pellared@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #8861 reported that
OTEL_EXPORTER_OTLP_METRICS_ENDPOINTURLs with a path could leak that path into the OTLP/gRPC dial target because the env config built the target withpath.Join(u.Host, u.Path).This PR updates OTLP metric env endpoint handling to use only
host:portfor HTTP(S) URLs while preserving fullunix://andunix-abstract://gRPC targets.It also adds regression tests that cover URL endpoints with paths and unix-family endpoints in the metric exporter env config paths.
Closes #8861.
Verifications:
cd exporters/otlp/otlpmetric/otlpmetricgrpc && go test ./... -count=1cd exporters/otlp/otlpmetric/otlpmetrichttp && go test ./... -count=1make golangci-lint/./exporters/otlp/otlpmetric/otlpmetricgrpcmake golangci-lint/./exporters/otlp/otlpmetric/otlpmetrichttp