Repository navigation
Allow producing complex jmx based metrics - #18782
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR extends the JMX metrics library to support βcomplexβ metrics produced by custom, user-provided logic via an SPI (JmxMetricHandler) referenced from YAML rules, and wires handler discovery through an injectable ComponentLoader/service classloader.
Changes:
- Add
JmxMetricHandlerSPI and YAML support (handler/handlers) to bind rules to custom metric producers. - Plumb a
ComponentLoaderfromJmxTelemetryBuilderinto the engine so handlers can be discovered via SPI at runtime. - Add lifecycle management for created instruments (returning
AutoCloseablehandles and closing registered instruments).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/jmx-metrics/library/src/test/resources/jmx/rules/handler.yaml | Adds a test rule referencing a custom handler by name. |
| instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/HandlerTest.java | New test validating handler discovery via SPI and metric emission. |
| instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricAggregationTest.java | Updates MetricDef construction for the new handlers parameter. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/JmxTelemetryBuilder.java | Adds service classloader injection and passes a ComponentLoader into JmxTelemetry. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/JmxTelemetry.java | Passes ComponentLoader into the engine and changes start* to return AutoCloseable. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/JmxMetricHandler.java | Introduces the public SPI for custom metric creation. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/yaml/RuleParser.java | Parses handler(s) keys and allows rules with handlers but no mapping. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/yaml/JmxRule.java | Stores handler references and builds MetricDef with handler names. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricRegistrar.java | Tracks created instruments and closes them; adds handler enrollment. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricHandlerHolder.java | New holder for handler + detection status to support (intended) refresh. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricExtractor.java | Makes status updates synchronized and returns βfirst enrollmentβ flag. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricDef.java | Adds handler list to metric definitions. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/JmxMetricInsight.java | Loads handlers via ComponentLoader and returns an AutoCloseable lifecycle handle. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/BeanFinder.java | Validates handler names and enrolls handlers when beans are found. |
| instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/BeanAttributeExtractor.java | Minor modernization (toArray(new String[0])) and annotation cleanup. |
Comments suppressed due to low confidence (1)
instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/BeanFinder.java:205
resolveHandlers()creates a newMetricHandlerHolderon everyrefreshState()run. SincerefreshState()is rescheduled indefinitely, this makesMetricRegistrar.enrollHandler()treat every run as a first enrollment, repeatedly creating/registering the same handler instruments and leaking resources/duplicating metrics. Persist the holder(s) across refresh cycles (e.g., storeMetricHandlerHolderinstances inMetricDefor inBeanFinderkeyed by rule+handlerName) and only create instruments once, updating status on subsequent refreshes (similar toMetricExtractor).
private void resolveHandlers(
Set<ObjectName> objectNames, MBeanServerConnection connection, MetricDef metricDef) {
for (String handlerName : metricDef.getHandlers()) {
JmxMetricHandler handler = handlers.get(handlerName);
// we remove rules that reference unknown handlers during construction, so this should never
// happen
if (handler == null) {
throw new IllegalStateException("Unknown handler " + handlerName);
}
MetricHandlerHolder holder = new MetricHandlerHolder(handler);
registrar.enrollHandler(connection, objectNames, holder);
}
| /** Starts JMX metrics collection on current JVM */ | ||
| public AutoCloseable start() { | ||
| return start(() -> MBeanServerFactory.findMBeanServer(null)); | ||
| } | ||
|
|
||
| /** | ||
| * Starts JMX metrics collection on provided (local or remote) connections | ||
| * | ||
| * @param connections connection provider | ||
| * @return this | ||
| */ | ||
| @CanIgnoreReturnValue | ||
| public JmxTelemetry start(Supplier<List<? extends MBeanServerConnection>> connections) { | ||
| service.start(metricConfiguration, connections); | ||
| return this; | ||
| public AutoCloseable start(Supplier<List<? extends MBeanServerConnection>> connections) { | ||
| return service.start(metricConfiguration, connections, componentLoader); | ||
| } |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricHandlerHolder.java:27
- [Naming]
handlerClassName/getHandlerClassName()is misleading: the YAMLhandlervalue is matched againstJmxMetricHandler.getName(), not a class name. Renaming this tohandlerName(and corresponding accessor) would make the intent clearer and reduce confusion for future maintenance.
private final String handlerClassName;
@Nullable private JmxMetricHandler handler;
@Nullable private volatile DetectionStatus status;
public MetricHandlerHolder(String handlerClassName) {
this.handlerClassName = handlerClassName;
}
String getHandlerClassName() {
return handlerClassName;
}
| public class MetricHandlerHolder { | ||
|
|
||
| private final String handlerName; | ||
| @Nullable private JmxMetricHandler handler; | ||
| @Nullable private volatile DetectionStatus status; | ||
|
|
||
| public MetricHandlerHolder(String handlerName) { | ||
| this.handlerName = handlerName; | ||
| } | ||
|
|
||
| String getHandlerName() { | ||
| return handlerName; | ||
| } | ||
|
|
||
| JmxMetricHandler getHandler() { | ||
| return handler; | ||
| } |
There was a problem hiding this comment.
MetricHandlerHolder is used from a different package and can't be package private
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/internal/engine/MetricRegistrar.java:255
close()catches allExceptions from instrument cleanup but doesnβt preserve the thread interrupt status when anInterruptedExceptionis caught (it will be swallowed and the interrupt flag cleared). Consider special-casingInterruptedExceptionto re-interrupt the thread after logging.
@Override
public void close() {
for (AutoCloseable instrument : instruments) {
try {
instrument.close();
} catch (Exception e) {
logger.log(WARNING, "Failed to close metric instrument", e);
}
}
instruments.clear();
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| void setHandler(JmxMetricHandler handler) { | ||
| if (this.handler != null) { | ||
| throw new IllegalStateException("Handler is already set"); | ||
| } |
There was a problem hiding this comment.
This isn't enough to make calling start multiple times work.
|
I think that it would be better to make the Then, all the available |
I chose to do it the way it is under the assumption that the vast majority of metrics can be expressed in yaml and there are going to be only a few that are too complicated. Since we have one yaml for each target that describes all the metrics I thought it would nice to have a reference from the yaml to these complex metrics.
Currently the Would it help if I named |
I think this is fine to keep it this way, I was just thinking about the possibility to have such an abstraction. The only use-case I would have for this is to provide an alternate YAML format, for example using the one used by weaver/semconv.
Yes, given we likely need to validate in a few iterations the design of this API with a few user-provided implementations then it would be a good idea to make it internal and have "Experimental" in its name. |
* Update version to 2.29.0-SNAPSHOT (open-telemetry#18790) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update all patch versions (open-telemetry#18793) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update quarkus packages to v3.35.3 (open-telemetry#18794) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Post-release updates for 2.28.0 (open-telemetry#18798) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update spotless packages to v8.5.1 (open-telemetry#18799) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18801) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * chore(deps): update weekly update (open-telemetry#18800) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Enable opentelemetry-api and opentelemetry-instrumentation-annotations even when default-enabled is false (open-telemetry#18792) * Rename Jetty and Tomcat common modules (open-telemetry#18786) * Rename OpenSearch REST common module (open-telemetry#18787) * Require telemetry stability in stable artifacts (open-telemetry#18789) * Capture pulsar message id earlier (open-telemetry#18803) * Increase timeout (open-telemetry#18805) * fix(deps): update dependency com.google.protobuf:protobuf-java-util to v4.35.0 (open-telemetry#18807) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18810) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update opentelemetry-java-contrib monorepo to v1.57.0-alpha (open-telemetry#18809) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * fix(deps): update quarkus packages to v3.36.0 (open-telemetry#18814) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Make waiting for gc ignore OutOfMemoryError (open-telemetry#18815) * Post-release updates for 2.28.1 (open-telemetry#18819) * Reduce the amount of test state (open-telemetry#18817) * Document constructor annotation behavior (open-telemetry#18797) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18821) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Ensure docker is started before running windows smoke tests (open-telemetry#18823) * Fix flaky tomcat requestWithException test (open-telemetry#18804) * Increase server stop timeout for finalge tests (open-telemetry#18827) * Fix flaky finagle future pool test (open-telemetry#18826) * Rename Spring WebMVC common module (open-telemetry#18788) * Rename Payara module to include base version (open-telemetry#18835) * Update pinned latest dep versions (open-telemetry#18840) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * chore(deps): update flint-managed linter updates to v0.2.0 (open-telemetry#18843) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Rename Spring common testing packages (open-telemetry#18839) * Update pinned latest dep versions (open-telemetry#18842) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update all patch versions (open-telemetry#18847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * chore(deps): update weekly update (open-telemetry#18848) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Change method to package private (open-telemetry#18849) * Clarify annotation instrumentation method matching (open-telemetry#18836) * Rename Quarkus RESTEasy Reactive and Tomcat JDBC modules (open-telemetry#18838) * JDBC url parsing for Amazon Aurora (open-telemetry#18831) * Disable kafka metrics by default in v3 (open-telemetry#18828) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix the bug where Redisson loses context during command execution. (open-telemetry#18701) Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * fix(ktor): resolve client hang on streaming path with Ktor 3.5.0 (open-telemetry#18781) * Use GraphQL to find the existing dashboard issue (open-telemetry#18856) Signed-off-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Rename OSHI and Elasticsearch transport common modules to include base version (open-telemetry#18854) * fix(deps): update spotless packages to v8.6.0 (open-telemetry#18861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove setup_migration_version from flint.toml (open-telemetry#18864) * Move servlet-common internal package under servlet.common.internal (open-telemetry#18855) * Fallback to old muzzle resolution when pinned versions file is missing (open-telemetry#18834) * Update pinned latest dep versions (open-telemetry#18858) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Update pinned latest dep versions (open-telemetry#18867) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Fix flaky tomcat exception tests (open-telemetry#18868) * fix(deps): update dependency checkstyle to v13.5.0 (open-telemetry#18870) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18869) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18872) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update all patch versions (open-telemetry#18877) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update gradle develocity packages to v4.4.2 (open-telemetry#18880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18881) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Fix deprection warning in build script (open-telemetry#18875) * fix(deps): update gradle shadow packages to v9.4.2 (open-telemetry#18882) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update graalvm buildtools packages to v1.1.1 (open-telemetry#18879) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Set instrumentation version on emitted Meter scopes (open-telemetry#18866) * Rename Akka and Scala forkjoin modules (open-telemetry#18772) * fix(deps): update byte buddy packages to v1.18.9 - abandoned (open-telemetry#18878) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Use SHA-256 for runtime telemetry package checksums (open-telemetry#18846) Signed-off-by: Israel Blancas <iblancasa@gmail.com> Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com> * Run @WithSpan instrumetnation after other instrumentations (open-telemetry#18874) * Update pinned latest dep versions (open-telemetry#18888) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Add opt-in support for emitting exceptions as log signals (open-telemetry#16259) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18895) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update jackson packages to v2.22.0 (open-telemetry#18871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * chore(deps): update weekly update (open-telemetry#18850) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Rename opentelemetry-instrumentation-api module to v1.14 and add v1_14 subpackage (open-telemetry#18887) * finagle: set read timeout only for read timeout test (open-telemetry#18897) * Consistent checking for read timeout uri (open-telemetry#18900) * Fix missing metric metadata for jdbc and oshi (open-telemetry#18901) * Update pinned latest dep versions (open-telemetry#18902) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update dependency net.ltgt.gradle:gradle-nullaway-plugin to v3.1.0 (open-telemetry#18906) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Align 3.0 deprecation markers in javaagent-extension-api (open-telemetry#18904) * Stream spotless output in PR triage script (open-telemetry#18910) * Clarify that config properties that contain the word `preview` are not stable (open-telemetry#18909) * Update pinned latest dep versions (open-telemetry#18917) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Preserve log total attribute count in tests (open-telemetry#18913) * Update pinned latest dep versions (open-telemetry#18931) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Fix metadata collection on Windows (open-telemetry#18928) * Collect Redisson 3.0 stable database telemetry (open-telemetry#18929) * Fix logback MDC declarative config keys (open-telemetry#18924) * Remove `network.type` from stable Cassandra db spans (open-telemetry#18920) * Prepare for SQLQueryAnalyzer analyze change in 3.0 (open-telemetry#18921) * Disable coroutine WithSpan by default in v3 preview (open-telemetry#18919) * aws-sdk-2.2: remove *AdviceBridge classes living in non-standard javaagent package (open-telemetry#18915) * aws-sdk-1.11: remove SqsAdviceBridge living in non-standard javaagent package (open-telemetry#18916) * Move nonstable semconv opt-ins to preview flag in 3.0 (open-telemetry#18914) * Move opentelemetry-api-1.0 instrumentation under v1_0 subpackage (open-telemetry#18886) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Remove deprecated db config names when v3 preview is enabled (open-telemetry#18934) Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> * Update metadata workflow to run on forks (open-telemetry#18940) * fix(deps): update okhttp monorepo to v5.4.0 (open-telemetry#18939) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix scope/telemetry attribution in metadata (open-telemetry#18941) * Update pinned latest dep versions (open-telemetry#18949) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update byte buddy packages to v1.18.10 (open-telemetry#18947) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Harden workflow input handling (open-telemetry#18946) * fix(deps): update armeria packages to v1.39.1 (open-telemetry#18944) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update quarkus packages to v3.36.1 (open-telemetry#18945) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add v3 preview config fallback (open-telemetry#18936) * chore(deps): update weekly update (open-telemetry#18942) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * fix(deps): update all patch versions (open-telemetry#18943) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Emit RPC exceptions as logs under the opt-in preview (open-telemetry#18890) * Emit DB exceptions as logs under the opt-in preview (open-telemetry#18889) * Emit FaaS exceptions as logs under the opt-in preview (open-telemetry#18892) * Emit messaging exceptions as logs under the opt-in preview (open-telemetry#18891) * Close BufferedWriter in code (open-telemetry#18923) Co-authored-by: tejasae-afk <tejasae-afk@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Exclude gh aw lockfiles from renovate update (open-telemetry#18950) * Support sqlite (open-telemetry#18885) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Preserve SQL query summary operation case (open-telemetry#18930) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add Couchbase 3.x stable db semconv support (open-telemetry#18926) * chore: update instrumentation list [automated] (open-telemetry#18857) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Emit GenAI exceptions as logs under the opt-in preview (open-telemetry#18893) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix NPE in Bedrock converseStream when tool use has empty arguments (open-telemetry#18783) * Allow producing complex jmx based metrics (open-telemetry#18782) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Fix peer service declarative config names metadata (open-telemetry#18883) * Fix DDL target case handling for password sanitization (open-telemetry#18927) * Add prettier to spotless (open-telemetry#18952) * Emit AWS SDK exceptions as logs under the opt-in preview (open-telemetry#18894) * chore: update instrumentation list [automated] (open-telemetry#18954) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Emit stable Cassandra operation and collection attributes (open-telemetry#18922) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update the OpenTelemetry SDK version to 1.63.0 (open-telemetry#18911) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Update pinned latest dep versions (open-telemetry#18955) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Module cleanup: batch of 19 modules (run 27261702849) (open-telemetry#18956) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Rename enduser attributes for v3 preview (open-telemetry#18795) * Update Jedis to stable database semconv (open-telemetry#18808) * fix(deps): update grpc-java monorepo to v1.82.0 (open-telemetry#18960) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update spring boot to v4.1.0 (open-telemetry#18961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update instrumentation list [automated] (open-telemetry#18962) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Restore OpenTelemetry API 1.47 incubator log bridge (open-telemetry#18959) * Update pinned latest dep versions (open-telemetry#18963) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * feat: Add support for SOFARPC framework (open-telemetry#15589) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * feat: Add support for HBase versions 2.0.0 to 2.5.0. (open-telemetry#18253) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Module cleanup: batch of 4 modules (run 27361345481) (open-telemetry#18965) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Module cleanup: batch of 2 modules (run 27362648931) (open-telemetry#18966) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Propagate Log4j appender context through async loggers (open-telemetry#18937) * Add db.collection.name to DynamoDB spans under stable database semconv (open-telemetry#18853) Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Rename common logging properties (open-telemetry#18851) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Update pinned latest dep versions (open-telemetry#18972) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update error-prone monorepo to v2.50.0 (open-telemetry#18957) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Fix DynamoDB stable database semconv (open-telemetry#18970) * chore: update instrumentation list [automated] (open-telemetry#18969) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Enable errorprone DefaultPackage check (open-telemetry#18973) * Clean up latest dependency override comments (open-telemetry#18968) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Capture Cassandra batch queries (open-telemetry#18964) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#18983) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update dependency checkstyle to v13.6.0 (open-telemetry#18996) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update instrumentation list [automated] (open-telemetry#18981) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Support Redisson batch operations (open-telemetry#18985) * Fix Vert.x Redis stable span names (open-telemetry#18986) * Prevent Lettuce Redis db.namespace being included in span names (open-telemetry#18984) * Add R2DBC batch size semconv attributes (open-telemetry#18980) * Fix DynamoDB batch attributes (open-telemetry#18979) * Update pinned latest dep versions (open-telemetry#18997) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Add back isMethod check in jedis instrumentation (open-telemetry#19000) * Add DB client collection semconv API (open-telemetry#18989) * Fix Couchbase stable DB span names (open-telemetry#18993) * Delete unnecessary @DisabledIfSystemProperty (open-telemetry#18999) * Fix Geode stable DB semconv attributes (open-telemetry#18992) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Mark nonstable JMX targets experimental (open-telemetry#18971) * Fix HBase stable DB semconv attributes (open-telemetry#18990) * Disable hbase tests on openj9 (open-telemetry#18998) * Fix daily workflow failure notifications (open-telemetry#19001) * Fix test label comment workflow (open-telemetry#19002) * Fix Mongo stable DB span names (open-telemetry#18987) * Add JDBC transaction duration metrics (open-telemetry#19003) * fix(deps): update all patch versions (open-telemetry#19013) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * fix(deps): update quarkus packages to v3.36.2 (open-telemetry#19015) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update weekly update (open-telemetry#18951) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Assert stable connection pool metric names in stable semconv mode (open-telemetry#19011) * chore: update instrumentation list [automated] (open-telemetry#19012) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Improve Vert.x SQL stable metric tests (open-telemetry#19010) * Improve Vert.x Redis stable metric test (open-telemetry#19009) * fix(deps): update graalvm buildtools packages to v1.1.2 (open-telemetry#19014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add Redisson batch size attribute (open-telemetry#19005) * Update pinned latest dep versions (open-telemetry#19016) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Add Vert.x SQL batch size attribute (open-telemetry#19004) Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * fix(deps): update spotless packages to v8.7.0 (open-telemetry#19017) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add thread details for declarative config via span processor (open-telemetry#19008) Signed-off-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Generate opt-in instrumentation version class (open-telemetry#19006) * Align SemconvStability with newer declarative config (open-telemetry#18908) Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Enable jvm.gc.cause attribute by default (open-telemetry#18967) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * fix(deps): update semconvversion to v1.42.0 (open-telemetry#19020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: update instrumentation list [automated] (open-telemetry#19022) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#19023) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Fix duplicate Pulsar multi-topic receive spans (open-telemetry#18771) Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> * Add another port wait for hadoop test (open-telemetry#19028) * Set query timeouts for camel cassandara test (open-telemetry#19026) * Set request timeout only for the read timeout test (open-telemetry#19025) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Run openserch asyn callbacks with parent context (open-telemetry#19027) * fix(deps): update dependency commons-logging:commons-logging to v1.4.0 (open-telemetry#19030) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update armeria packages to v1.40.0 (open-telemetry#19032) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update quarkus packages to v3.37.0 (open-telemetry#19031) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update pinned latest dep versions (open-telemetry#19033) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> * Draft release notes (open-telemetry#19040) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * [release/v2.29.x] Prepare release 2.29.0 (open-telemetry#19042) Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> --------- Signed-off-by: Trask Stalnaker <trask.stalnaker@gmail.com> Signed-off-by: Israel Blancas <iblancasa@gmail.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: otelbot[bot] <197425009+otelbot[bot]@users.noreply.github.com> Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <ltulmin@splunk.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: YaoYingLong <906271196@qq.com> Co-authored-by: Adrian McCague <amccague@gmail.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com> Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com> Co-authored-by: Tejas Attarde <201814263+tejasae-afk@users.noreply.github.com> Co-authored-by: tejasae-afk <tejasae-afk@users.noreply.github.com> Co-authored-by: Michael Dent <vikinghawk@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: otelbot-java-instrumentation[bot] <212412449+otelbot-java-instrumentation[bot]@users.noreply.github.com> Co-authored-by: Stefano Pace <stefanopace01@gmail.com> Co-authored-by: Me1iodas <fangxiu.wf@alibaba-inc.com> Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com> Co-authored-by: Egor Fatyushin <Egor.Fatyushin@skyscanner.net> Co-authored-by: somil jain <somil16022006@gmail.com>
Resolves #17433
Some metrics are too complex to be expressed in yaml. This PR allows implementing such metrics in code.