Skip to content

chore: Add v8js.resource.active metrics and v8js.resource.type attributes - #3445

Merged
lmolkova merged 1 commit into
open-telemetry:mainfrom
sfozz:add_v8js_metrics
Apr 24, 2026
Merged

lmolkova merged 1 commit into
open-telemetry:mainfrom
sfozz:add_v8js_metrics

Conversation

@sfozz

@sfozz sfozz commented Feb 16, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Add v8js.resource.active metric and v8js.resource.type attribute to track resources keeping the event loop active.

Example Prior work

Related PR

open-telemetry/opentelemetry-js-contrib#3361

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@kamphaus

Copy link
Copy Markdown
Contributor

You need to add metric.v8js.active_resource to model/v8js/metrics.yaml and v8js.active_resource.type to model/v8js/registry.yaml.

Comment thread docs/registry/attributes/v8js.md Resolved
Comment thread docs/runtime/v8js-metrics.md Resolved
Comment thread docs/runtime/v8js-metrics.md Resolved
@sfozz
sfozz requested a review from thompson-tomo February 18, 2026 02:02
Comment thread docs/runtime/v8js-metrics.md Resolved
@sfozz
sfozz requested a review from thompson-tomo February 18, 2026 04:53
@sfozz
sfozz requested a review from kamphaus February 18, 2026 05:54
@sfozz sfozz changed the title chore: Add v8js.active_resource metrics and attributes chore: Add v8js.resource.active metrics and v8js.active.type attributes Feb 19, 2026
@sfozz sfozz changed the title chore: Add v8js.resource.active metrics and v8js.active.type attributes chore: Add v8js.resource.active metrics and v8js.resource.type attributes Feb 19, 2026
@lmolkova

Copy link
Copy Markdown
Member

@maryliag could you please take a look?

@lmolkova
lmolkova requested review from maryliag and removed request for thompson-tomo February 20, 2026 03:18
@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Feb 20, 2026

@maryliag maryliag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as tests are passing, LGTM

Comment thread model/v8js/metrics.yaml Resolved
@github-project-automation github-project-automation Bot moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Feb 25, 2026
Comment thread model/v8js/registry.yaml Resolved
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • v8js

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@github-actions

Copy link
Copy Markdown

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days.

@github-actions github-actions Bot added the Stale label Mar 24, 2026
@sfozz

sfozz commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

bump

@github-actions github-actions Bot removed the Stale label Mar 25, 2026
@maryliag

maryliag commented Apr 7, 2026

Copy link
Copy Markdown
Member

cc @lmolkova if you have any other feedback or if this can be approved/merged

@sfozz
sfozz requested a review from lmolkova April 16, 2026 01:00
@lmolkova
lmolkova added this pull request to the merge queue Apr 24, 2026
Merged via the queue into open-telemetry:main with commit 4758051 Apr 24, 2026
20 of 23 checks passed
@sfozz
sfozz deleted the add_v8js_metrics branch April 24, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants