Skip to content

Update naming.md to clarify 'duration' definition - #3543

Merged
trask merged 7 commits into
open-telemetry:mainfrom
lahabana:patch-1
Apr 21, 2026
Merged

trask merged 7 commits into
open-telemetry:mainfrom
lahabana:patch-1

Conversation

@lahabana

Copy link
Copy Markdown
Contributor

Part of #816

Changes

time and duration are close but slightly different ways to instrument times.

There are plenty of examples in this doc with duration yet it wasn't defined in the instrument naming section.

@jack-berg explained in this comment clearly the difference between time and duration.

This attempts to update the documentation to persist this information by documenting duration and explaining when to use it compared to time.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

**time** and **duration** are close but slightly different ways to instrument times.

There are plenty of examples in this doc with **duration** yet it wasn't defined in the instrument naming section.

@jack-berg explained in [this comment](open-telemetry#816 (comment)) clearly the difference between **time** and **duration**.

This attempts to update the documentation to persist this information by documenting **duration** and explaining when to use it compared to **time**.

Part of open-telemetry#816

@lmolkova lmolkova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, it makes sense, just left some comments to make it more precise

Comment thread docs/general/naming.md Resolved
Comment thread docs/general/naming.md Resolved
Comment thread docs/general/naming.md Resolved
Comment thread docs/general/naming.md Resolved
Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
@lahabana

Copy link
Copy Markdown
Contributor Author

Thanks for clarifying @lmolkova I've included your suggestions.

Comment thread docs/general/naming.md Resolved
Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
@lahabana

Copy link
Copy Markdown
Contributor Author

@lmolkova updated. Changelog fails does it really make sense to add an entry in the Changelog for this?

@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Mar 25, 2026
Comment thread docs/general/naming.md Resolved
lahabana added 2 commits April 1, 2026 10:12
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
lahabana requested review from kamphaus and lmolkova April 1, 2026 08:15
Comment thread docs/general/naming.md Resolved
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Apr 3, 2026
@lmolkova

lmolkova commented Apr 3, 2026

Copy link
Copy Markdown
Member

Changelog fails does it really make sense to add an entry in the Changelog for this?

@lahabana no need, I added label to skip changelog, adding [chore] to the title would also do the job

@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Apr 3, 2026
@trask
trask enabled auto-merge April 20, 2026 15:09
Comment thread docs/general/naming.md Resolved
Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
@trask
trask added this pull request to the merge queue Apr 21, 2026
Merged via the queue into open-telemetry:main with commit b95c3a6 Apr 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Label to skip the changelog check

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants