Skip to content

Live-check: Add overrides to rewrite matching finding levels - #1625

Merged
jerbly merged 3 commits into
open-telemetry:mainfrom
jerbly:rewrite-finding-levels
Jul 23, 2026
Merged

jerbly merged 3 commits into
open-telemetry:mainfrom
jerbly:rewrite-finding-levels

Conversation

@jerbly

@jerbly jerbly commented Jul 23, 2026

Copy link
Copy Markdown
Member

Fixes: #1614

add [[live-check.finding_level_overrides]] to rewrite a finding's level instead of dropping it (e.g. treat undefined_enum_variant as a violation), scoped by the same signal_type/sample_names rules as finding_filters.

Now you can do this:

# undefined_enum_variant is information by default; treat it as a violation everywhere
[[live-check.finding_level_overrides]]
ids = ["undefined_enum_variant"]
level = "violation"

# ...or only for a specific set of attributes on spans
[[live-check.finding_level_overrides]]
ids = ["undefined_enum_variant"]
level = "violation"
signal_type = "span"
sample_names = ["http.*"]

@jerbly
jerbly requested a review from a team as a code owner July 23, 2026 00:34
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-23 02:27:44 UTC.

  • Status: Merged.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 81.5%. Comparing base (3b517a1) to head (dc2cf19).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1625   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        130     130           
  Lines      11598   11616   +18     
=====================================
+ Hits        9454    9474   +20     
+ Misses      2144    2142    -2     

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerbly
jerbly merged commit 2c8cc25 into open-telemetry:main Jul 23, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

live-check: finding modifier to rewrite advice level

3 participants