Repository navigation
Fix attributes with no stability being dropped in the v1 to v2 conversion - #1695
Merged
jsuereth merged 4 commits intoAug 13, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-08-13 22:26 UTC Status above doesn't look right?
|
8 tasks done
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
- Coverage 81.6% 81.6% -0.1%
=======================================
Files 131 131
Lines 11829 11826 -3
=======================================
- Hits 9656 9652 -4
- Misses 2173 2174 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jsuereth
reviewed
Aug 13, 2026
| .as_ref() | ||
| .map(|s| a.common.stability == *s) | ||
| .unwrap_or(false) | ||
| // A v1 attribute can have no stability. The catalog |
jsuereth
approved these changes
Aug 13, 2026
jsuereth
enabled auto-merge (squash)
August 13, 2026 13:01
lmolkova
approved these changes
Aug 13, 2026
| == *attribute | ||
| .stability | ||
| .as_ref() | ||
| .unwrap_or(&weaver_semconv::stability::Stability::Alpha) |
Member
There was a problem hiding this comment.
nit,
Suggested change
| .unwrap_or(&weaver_semconv::stability::Stability::Alpha) | |
| .unwrap_or(&weaver_semconv::stability::Stability::Development) |
(even before alpha, this is where all semconv start)
Member
Author
There was a problem hiding this comment.
This was more than a one line change because this was used in the comparison so it need to change on both sides of that. But, since development is the default this turns out neater anyway. See 2347282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog::convert_reflooks up a v1 attribute in the v2 catalog by comparing every field, and the stability clause read.map(|s| a.common.stability == *s).unwrap_or(false). An attribute with nostabilitytherefore never matched. The catalog itself is built withstability.unwrap_or(Alpha), so the entry was there all along — the lookup just could not reach it. This PR applies the sameAlphadefault on the lookup side.A missing stability is only a warning, so registries like this resolve and reach the conversion. Every signal loop calls
convert_refand skips the attribute when it returnsNone, so spans, events, metrics and attribute groups all lost it in silence. Entities are where it shows: an entity that loses an identity attribute has no identity, andregistry package --v2shippedidentity: []with a zero exit code.The entity loop also hit an
else { // TODO logic error! }, which is now aconvert_attribute_refhelper returningAttributeNotFound.This is the second of a series of small PRs for entity association resolution, and it is independent of the others.