Repository navigation
Refactor live-check to combine otlp and admin api flow - #1770
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 142 142
Lines 13707 13707
=======================================
- Hits 11459 11458 -1
- Misses 2248 2249 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jerbly
marked this pull request as ready for review
September 16, 2026 00:03
Pull request dashboard statusMerged · refreshed 2026-09-26 01:42 UTC Status above doesn't look right?
|
jsuereth
approved these changes
Sep 25, 2026
|
|
||
| Three things make this safe: | ||
|
|
||
| - An export is acknowledged only after it is queued for checking. When the app's |
Contributor
There was a problem hiding this comment.
I'm not sure I buy this from claude.
It's safer but not guaranteed.
The key in my mind is just /report vs /stop being split. That's the win. This is a bit of an overreaching statement.
| //! | ||
| //! The phase is the whole state of the run, and the one thing everyone waits on. | ||
| //! | ||
| //! Weaver acts on what it is told, a flag or a request, and never invents an |
Contributor
There was a problem hiding this comment.
Nit: Any chance we can turn this back into human?
Contributor
There was a problem hiding this comment.
This is MUCH cleaner, nice!
…live-check-modes-pr1
jerbly
enabled auto-merge (squash)
September 26, 2026 01:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1657
registry live-check --output http:POST /stopno longer returns the report. It stops the run and returns once the report is ready. Read the report with the newGET /report, then end the process with the newPOST /shutdown. Reading the report is no longer tied to the process exiting, so large reports are never truncated. In this mode--inactivity-timeoutis ignored: the client owns the run.Internally the OTLP gRPC services and the admin API are now one axum app on one thread with one runtime. The run's state is a single
watch<Phase>with three variants, next to the bounded export channel. There are no server-side timers in http mode.The weaver-live-check-stop action now calls stop, report, shutdown, and still accepts the old /stop body from earlier releases.
docs/http-api.mdin the live-check crate has a sequence diagram and a worked script.This first PR sets up for a sequence of PRs in this area and leads towards a potential split across all weaver functionality of either CLI or API run modes.