Skip to content

Refactor live-check to combine otlp and admin api flow - #1770

Merged
jerbly merged 7 commits into
open-telemetry:mainfrom
jerbly:live-check-modes-pr1
Sep 26, 2026
Merged

jerbly merged 7 commits into
open-telemetry:mainfrom
jerbly:live-check-modes-pr1

Conversation

@jerbly

@jerbly jerbly commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Fixes #1657

registry live-check --output http: POST /stop no longer returns the report. It stops the run and returns once the report is ready. Read the report with the new GET /report, then end the process with the new POST /shutdown. Reading the report is no longer tied to the process exiting, so large reports are never truncated. In this mode --inactivity-timeout is ignored: the client owns the run.

Internally the OTLP gRPC services and the admin API are now one axum app on one thread with one runtime. The run's state is a single watch<Phase> with three variants, next to the bounded export channel. There are no server-side timers in http mode.

The weaver-live-check-stop action now calls stop, report, shutdown, and still accepts the old /stop body from earlier releases. docs/http-api.md in the live-check crate has a sequence diagram and a worked script.

This first PR sets up for a sequence of PRs in this area and leads towards a potential split across all weaver functionality of either CLI or API run modes.

@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.5%. Comparing base (fa58691) to head (976e215).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1770     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files        142     142             
  Lines      13707   13707             
=======================================
- Hits       11459   11458      -1     
- Misses      2248    2249      +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerbly
jerbly marked this pull request as ready for review September 16, 2026 00:03
@jerbly
jerbly requested a review from a team as a code owner September 16, 2026 00:03
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-09-26 01:42 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.


Three things make this safe:

- An export is acknowledged only after it is queued for checking. When the app's

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I buy this from claude.

It's safer but not guaranteed.

The key in my mind is just /report vs /stop being split. That's the win. This is a bit of an overreaching statement.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 976e215

Comment thread src/registry/otlp/admin.rs Outdated
//!
//! The phase is the whole state of the run, and the one thing everyone waits on.
//!
//! Weaver acts on what it is told, a flag or a request, and never invents an

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Any chance we can turn this back into human?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 976e215

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is MUCH cleaner, nice!

@jerbly
jerbly enabled auto-merge (squash) September 26, 2026 01:38
@jerbly
jerbly merged commit ff62011 into open-telemetry:main Sep 26, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

registry live-check --output http: /stop still truncates the report on HTTP/1.1 when the client drains the body slowly

2 participants