Repository navigation
Pin Datafaker to 1.x when migrating from Java Faker - #1199
Merged
Merged
Conversation
ChangeDependency without a newVersion kept the Java Faker version, and net.datafaker:datafaker:1.0.2 does not exist. 1.x resolves to 1.9.0, the last Java 8 release, which also has the providers.base types the recipe renames to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaFakerToDataFakerswappedcom.github.javafaker:javafakerfornet.datafaker:datafakerwithout anewVersion, so it kept the old version, andnet.datafaker:datafaker:1.0.2has never been published, which caused aMavenDownloadingExceptionon any project using the last Java Faker release.The dependency change now uses
newVersion: 1.x, which resolves to 1.9.0: the last Datafaker release that runs on Java 8 (2.x requires Java 17), and new enough (1.7.0+) to have theproviders.base.HashingandRelationshiptypes the recipe renames to.A new test migrates a pom on
javafaker:1.0.2todatafaker:1.9.0; without the fix it fails with the same download error.