Repository navigation
Let rewriteRun verify the JUnit 4 to 5 migration settles - #1209
Merged
Merged
Conversation
cycles(1).expectedCyclesThatMakeChanges(1) skipped the cycle that checks the recipe changes nothing more. The default of two cycles runs it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddJupiterDependenciesTestandAddHamcrestIfUsedTestpinnedcycles(1).expectedCyclesThatMakeChanges(1), sorewriteRunnever ran the cycle that checks the JUnit 4 to 5 migration changes nothing more. The migration settles, so the pins go, and the default two cycles run that check.declaresParametersGeneratedByJUnitParamsInOneCyclestill asserts a single changing cycle.This is part of removing cycle pins ahead of openrewrite/rewrite#9359, and it doesn't depend on it. Both classes pass (16 tests).
ReplacePowerMockitoIntegrationTest, which gains a verification cycle under #9359, also passes against rewrite-test built from it.