Repository navigation
Preserve public test fixtures referenced from other packages - #1248
Merged
jkschneider merged 6 commits intoOct 26, 2026
Merged
Conversation
Co-authored-by: Moderne Factory <factory@moderne.io>
Co-authored-by: Moderne Factory <factory@moderne.io>
Co-authored-by: Moderne Factory <factory@moderne.io>
Co-authored-by: Moderne Factory <factory@moderne.io>
Co-authored-by: Moderne Factory <factory@moderne.io>
Co-authored-by: Moderne Factory <factory@moderne.io>
jkschneider
deleted the
factory/testing458-preserve-foreign-test-fixtures
branch
October 26, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestsShouldNotBePublic can remove public from a fixture class that another package imports or references, leaving the migrated sources uncompilable. Preserve class visibility for attributed foreign references and their owning classes, and for explicit imports that still require access even when their type metadata is absent.
Track these references separately from inherited lifecycle method eligibility. Resolve static-import fallback names from identifier segments so nested classes remain accessible with comments or whitespace in imports. Same-package and unrelated-class cleanup remains eligible; declarations without type metadata are retained conservatively.
Validation:
Coverage is bounded by attributed code references and explicit imports in the available source set. This does not claim complete detection of unknown external consumers or unresolved wildcard-only references.
Fixes #458.
Co-authored-by: Moderne Factory factory@moderne.io