Repository navigation
Upgrade Byte Buddy along with Mockito where a BOM manages it - #1278
Merged
Merged
Conversation
krlittle
changed the title
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
New
UpgradeByteBuddyForMockito3,UpgradeByteBuddyForMockito4andUpgradeByteBuddyForMockito5, called from the matching Mockito upgrades. Whenmockito-coreresolves to that major and Byte Buddy resolves to something older than that Mockito needs,byte-buddyandbyte-buddy-agentare bumped withUpgradeTransitiveDependencyVersion.What's your motivation?
With a Spring Boot 2 parent Byte Buddy is managed (1.9.13 for 2.1), so taking Mockito past what the BOM manages leaves every mock failing with
Hit this on sflpro/notifier after migrating it from EasyMock.
Anything in particular you'd like reviewers to focus on?
Both checks are
DependencyInsightpreconditions, so they see the dependencies after the Mockito upgrade earlier in the same run. Without the Byte Buddy check it also pinned 1.17.8 over the 1.17.7 that Mockito 5.24 already brings, in projects that didn't need anything.