[greg-at-moderne]

What's changed?

AssertionsArgumentOrder now creates its UsesMethod precondition visitors inside each getVisitor() call. Before, it kept them in a static field that every thread shared.

Also the same change in AddMissingNested and LifecycleNonPrivate, but only as a precaution. In practice UsesType is thread-safe, but not guaranteed to be.

What's your motivation?

OpenRewriteRecipeBestPractices fails on random test files in nightly Moderne runs, with 1–12 files a night across several repos. UsesMethod keeps a cursor, and when files run in parallel one thread resets that cursor while another is still using it:

java.lang.NullPointerException: Cannot invoke "org.openrewrite.Cursor.getMessage(String, Object)" because "this.cursor" is null
  org.openrewrite.TreeVisitor.visit(TreeVisitor.java:237)
  org.openrewrite.Preconditions$Or.visit(Preconditions.java:120)
  org.openrewrite.Preconditions$Or.visit(Preconditions.java:103)
  org.openrewrite.TreeVisitor.visit(TreeVisitor.java:147)
  org.openrewrite.Preconditions$Check.visit(Preconditions.java:184)
  org.openrewrite.Preconditions$Check.visit(Preconditions.java:156)
  org.openrewrite.scheduling.RecipeRunCycle.lambda$editSource$10(RecipeRunCycle.java:538)