You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
--language:js seems to disable inlining in native images #4473
Based on what we discussed in this Spring Native issue, using --language:js seems to disable inlining like if -H:-InlineBeforeAnalysis was applied, breaking Spring Boot applications compiled with Spring Native.
@sdeleuze Yes, currently method inlining before analysis is not supported when a Truffle language is in the image. This requires a pretty big rewrite of how we compile the deoptimization entry points. We know how to do it, but just did not have the time yet to get it implemented.
So the main question is: how important is that for you? Do you have use cases where you want to integrate JavaScript into Spring applications?
This issue is still pending and prevents any Spring Boot 3 application to enable the language support, see https://github.com/eregon/truffleruby-embed-spring. Any chance you could remove this limitation?
We are actively working on removing this limitation, but it requires many changes. I'll post an update here when InlineBeforeAnalysis is compatible with Truffle languages
Reacted by Lucas Jeremías Couchot, Sébastien Deleuze, Septiyan Herlan and Samuel Vazquez
We have been working on the necessary changes for a while, so there is a good chance it will be ready for GraalVM 23.1 in fall. But until everything is working, we cannot guarantee it.
Reacted by Sébastien Deleuze, Noah Neukam and Michele Santoro
Hello @christianwimmer, based on the lack of activity for almost a year, I understand that this was not fixed yet nor you're planning to include a fix soon.
Is that correct?
Activity
oubidar-Abderrahim commentedon Apr 8, 2022
Thank you for reporting this, we will take a look and get back to you, in the meantime could you share the steps to reproduce the issue
LilPoppy commentedon Apr 8, 2022
Hi @oubidar-Abderrahim
Pull newest from repository first:
git clone https://github.com/StorebeansDev/cobnet.gitCheck if you have any Redis port opening:
sudo lsof -i :6379Kill the redis if you have any exists:
kill -9 [pid]Then run the following:
mvn -Dredis-host=redis -Ddb-host=db clean install -Pdocker -Ddocker-target=nativeAfter done container run:
docker start -a cobnetsdeleuze commentedon Apr 10, 2022
Can be reproduced without that with just a simple Spring webapp.
oubidar-Abderrahim commentedon Apr 11, 2022
Thank you @sdeleuze, could you please share the simple Spring webapp for clarity?
sdeleuze commentedon Apr 11, 2022
Sure:
samples/webflux-netty, add@NativeHint(options = "--language:js")toWebfluxApplication./build.shoubidar-Abderrahim commentedon Apr 26, 2022
Hi @sdeleuze ,
I couldn't reproduce the issue using the steps you provided, here is what I did:
the output I get:
Am I missing something? what version of GraalVM did you reproduce with? jdk11 or 17? CE or EE? which OS? (I tested on Linux amd64 Ubuntu 18.04)
michelu89 commentedon May 3, 2022
Hi @oubidar-Abderrahim,
The problem when testing my Spring application comes to a similar problem as @sdeleuze mentioned.
What are my steps:
starting the executable it get this output:
oubidar-Abderrahim commentedon May 4, 2022
Tracked internally on GR--38563
christianwimmer commentedon May 4, 2022
@sdeleuze Yes, currently method inlining before analysis is not supported when a Truffle language is in the image. This requires a pretty big rewrite of how we compile the deoptimization entry points. We know how to do it, but just did not have the time yet to get it implemented.
So the main question is: how important is that for you? Do you have use cases where you want to integrate JavaScript into Spring applications?
2 remaining items
christianwimmer commentedon Jun 10, 2022
I have this issue on the list to be addressed over the next months, I hope we get it done for the 22.3 release in fall.
sdeleuze commentedon Dec 21, 2022
This issue is still pending and prevents any Spring Boot 3 application to enable the language support, see https://github.com/eregon/truffleruby-embed-spring. Any chance you could remove this limitation?
teshull commentedon Dec 21, 2022
We are actively working on removing this limitation, but it requires many changes. I'll post an update here when InlineBeforeAnalysis is compatible with Truffle languages
samuelAndalon commentedon Apr 22, 2023
just faced the same problem, currently trying the js support in a native image with Spring Boot 3
sdeleuze commentedon Apr 24, 2023
Any chance to fix that in next major release?
christianwimmer commentedon Apr 24, 2023
We have been working on the necessary changes for a while, so there is a good chance it will be ready for GraalVM 23.1 in fall. But until everything is working, we cannot guarantee it.
otcyury commentedon May 23, 2023
Will --language:js use with native build work with latest Quarkus based apps?
oliveryasuna commentedon Jun 21, 2023
Facing this problem with
--language:pythonin GraalVM 22.3.r17-grl.nsoubelet commentedon Jan 27, 2024
Hello @christianwimmer, based on the lack of activity for almost a year, I understand that this was not fixed yet nor you're planning to include a fix soon.
Is that correct?
teshull commentedon Jan 27, 2024
Hi, with the release of 23.1, InlineBeforeAnalysis is compatible with Truffle languages.