Skip to content

projects lost when merging per-project setting in read-only configuration with active configurationย #2147

Open

Description

@vladak

https://github.com/oracle/opengrok/wiki/Per-project-configuration advises to put per-project configuration into read-only configuration file. However when merged with a configuration retrieved from webapp that already contains some projects via:

/opengrok/dist/bin/projadm.py -b /opengrok -R /opengrok/etc/readonly_configuration.xml -r

the resulting configuration.xml will only have the projects specified in read-only configuration.

Activity

  1. vladak commented on Jun 8, 2018

    @vladak
    MemberAuthor

    One way how to deal with this would be to change the workflow - augment the Project Message to be able to set per-project properties and then retrieve the configuration so that it is persistent.

  2. vladak commented on Jun 8, 2018

    @vladak
    MemberAuthor

    I think this is a fall-out of how XML serialization is done. As a result, merge is not really a merge.

  3. added a commit that references this issue on Jun 11, 2018
  4. vladak commented on Jun 11, 2018

    @vladak
    MemberAuthor

    Possibly as a fix the configuration merge needs to be more intelligent.

  5. tulinkry commented on Jun 11, 2018

    @tulinkry
    Contributor
  6. added a commit that references this issue on Jun 14, 2018
  7. vladak commented on Jul 13, 2018

    @vladak
    MemberAuthor

    This has a workaround so stripping the stopper tag for now.

  8. vladak commented on Aug 31, 2018

    @vladak
    MemberAuthor

    Thel workaround needs a tweak for full global (not per project) indexing - I believe the per-project setting in read-only configuration is applied after the projects are discovered however once the initial index is done, the per-project settings have to be removed from read-only configuration and set in the webapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions