Improved pull request "Files Changed" experience feedback #163932
Replies: 3339 comments 1390 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now π I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
Sorry if this already requested elsewhere (Github is telling me there are 3k hidden msgs on this thread) but would be great if the one file at a time mode preloaded the next few files. |
|
I've been building a Chrome / Firefox extension that makes the Files Changed view a lot better (among other things) if folks want to check it out :) "fixes" a bunch of things that bother me about this view. If anyone has suggestions for improvements, please feel free to file an issue! |
|
I can't tell if this is from this item or the other pull request refresh, but Ideally links that can be shared should survive mutations including application of their suggestions. The simplest fix would be for links to have the full form (including whatever the |
Why?? This has made code review super difficult :( |
|
Previously, all changed files, regardless of whether they were newly added or modified, were displayed consistently on the right side. This made it easier to review changes because I could keep my focus on one side of the screen. With the latest UI, newly added files are displayed from left to right, while modified changes follow a different layout. This makes the review experience feel less consistent. It would be great to keep all changed files aligned on the right side, regardless of their status (new or modified), as in the previous layout. |
|
Apologies if it's repeated, but links direct to review comments are not properly displaying the comment, they just lead to the base PR page |
|
|
In PR File change tab, I would like to request for showing "Total Opening PR comments" that needs to be resolved |
|
As a screenreader user, I am still unable to fully adopt this new "Files changed" experience. But I lose some time and even have difficulties reading existing comments while reviewing the code or other comments and understanding the state of the PR:
And overall, providing feedback in this unique discussion with more than 1000 replies just makes tracking of all improvements impossible!!! Each one provide their comment and these comments seem to go into a bottomless well. Then one day, we notice GUI changes and we do not know if these changes are due to modifications made by the GitHub dev team or to a transient bug. |
|
Can you make it so that generated files appear as "Viewed" by default? Marking files as generated hides the diff but they still appear and we still need to manually mark them as viewed. This makes the "generated file" marker quite useless, in the end the workflow is the same, it just takes less space on the screen. |
|
π€ I don't know if this is a feature or bug, but if I'm in "Files changed" view and I pushed new commit, it doesn't automatically reflect, nor does it show "Refresh" button like before. Is this expected? π«€ @Akash1134 |
|
Hi. Previously, when I scrolled down (for example in the "Files changed" section), the top menu with the |
|
I've been having trouble scrolling back up after refreshing a PR with a 15ish unviewed files in a 30-ish file PR. I can bypass this by dragging the scroll bar to the top of the PR, and then scrolling down from the top. |















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the β¨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
β¨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
β¨ Updates
See what's been fixed and improved since the launch of the public preview:
π‘ Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, weβre increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experienceβwe read every comment!
All reactions