Skip to content

[RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 [RHEL-95416] - #4759

Merged
achilleas-k merged 2 commits into
osbuild:rhel-8.10.0from
achilleas-k:r8.10/bump/images
Jul 9, 2025
Merged

achilleas-k merged 2 commits into
osbuild:rhel-8.10.0from
achilleas-k:r8.10/bump/images

Conversation

@achilleas-k

@achilleas-k achilleas-k commented Jun 25, 2025 •

Copy link
Copy Markdown
Member

Fixes the size of the ISO rootfs to fit the anaconda tree for the edge-installer.

See osbuild/image-builder#1594

@achilleas-k
achilleas-k requested a review from a team as a code owner June 25, 2025 17:00
@achilleas-k
achilleas-k requested review from mvo5, supakeen and thozza and removed request for a team June 25, 2025 17:00
@achilleas-k
achilleas-k changed the base branch from main to rhel-8.10.0 June 25, 2025 17:00
@achilleas-k

Copy link
Copy Markdown
Member Author

We're going to need more test setup fiddling

@achilleas-k
achilleas-k force-pushed the r8.10/bump/images branch 5 times, most recently from 1c50279 to d4111be Compare June 26, 2025 15:19
mvo5
mvo5 previously approved these changes Jun 26, 2025

@thozza thozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the CI work on the rhel-X.Y.0 branches is always soooo painful 😭

My random comments/thoughts:

  • Are changes to tools/koji-compose.py needed when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all.
  • The same applies to the Cloud API tests (api.sh) - we don't need to keep testing them.
  • The triggering of nightly tests in .github/workflows/trigger-gitlab.yml needs to be removed.
  • In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.

@achilleas-k

Copy link
Copy Markdown
Member Author
  • Are changes to tools/koji-compose.py needed when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all.

Not really no. But I had to update the Lint job runner, which updated the linter, which caught issues with the old version of the script. So I decided it's simpler to pull in the new version of the script to make the linter happy rather than disable the check. If the changes were more substantial I would have disabled it, but it's only a few lines.

  • The same applies to the Cloud API tests (api.sh) - we don't need to keep testing them.

True. Those I'll disable.

  • The triggering of nightly tests in .github/workflows/trigger-gitlab.yml needs to be removed.

Yup. On it.

  • In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.

That's a good idea. I'll start a new PR for the CI reduction.

@achilleas-k
achilleas-k marked this pull request as draft June 27, 2025 12:46
@achilleas-k

Copy link
Copy Markdown
Member Author

Test update PR: #4764

@achilleas-k
achilleas-k marked this pull request as ready for review July 9, 2025 09:31
@achilleas-k achilleas-k changed the title [RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 [RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 [RHEL-95416] Jul 9, 2025

@thozza thozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@achilleas-k
achilleas-k merged commit 377ee5f into osbuild:rhel-8.10.0 Jul 9, 2025
@achilleas-k
achilleas-k deleted the r8.10/bump/images branch July 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants