Repository navigation
[RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 [RHEL-95416] - #4759
Merged
Merged
Conversation
achilleas-k
requested review from
mvo5,
supakeen and
thozza
and removed request for
a team
June 25, 2025 17:00
Member
Author
|
We're going to need more test setup fiddling |
achilleas-k
force-pushed
the
r8.10/bump/images
branch
5 times, most recently
from
June 26, 2025 15:19
1c50279 to
d4111be
Compare
mvo5
previously approved these changes
Jun 26, 2025
thozza
reviewed
Jun 27, 2025
thozza
left a comment
Member
There was a problem hiding this comment.
Getting the CI work on the rhel-X.Y.0 branches is always soooo painful 😭
My random comments/thoughts:
- Are changes to
tools/koji-compose.pyneeded when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all. - The same applies to the Cloud API tests (
api.sh) - we don't need to keep testing them. - The triggering of nightly tests in
.github/workflows/trigger-gitlab.ymlneeds to be removed. - In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.
achilleas-k
force-pushed
the
r8.10/bump/images
branch
from
June 27, 2025 12:19
d4111be to
943afb0
Compare
Member
Author
Not really no. But I had to update the Lint job runner, which updated the linter, which caught issues with the old version of the script. So I decided it's simpler to pull in the new version of the script to make the linter happy rather than disable the check. If the changes were more substantial I would have disabled it, but it's only a few lines.
True. Those I'll disable.
Yup. On it.
That's a good idea. I'll start a new PR for the CI reduction. |
achilleas-k
marked this pull request as draft
June 27, 2025 12:46
Member
Author
|
Test update PR: #4764 |
achilleas-k
force-pushed
the
r8.10/bump/images
branch
from
July 9, 2025 09:31
943afb0 to
4d813f1
Compare
achilleas-k
marked this pull request as ready for review
July 9, 2025 09:31
achilleas-k
force-pushed
the
r8.10/bump/images
branch
from
July 9, 2025 09:34
4d813f1 to
56423a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the size of the ISO rootfs to fit the anaconda tree for the edge-installer.
See osbuild/image-builder#1594