Skip to content

test: remove timestamps from greenprint functions - #5268

Merged
achilleas-k merged 1 commit into
osbuild:mainfrom
achilleas-k:test/greenprint-no-time
Oct 8, 2026
Merged

achilleas-k merged 1 commit into
osbuild:mainfrom
achilleas-k:test/greenprint-no-time

Conversation

@achilleas-k

@achilleas-k achilleas-k commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Timestamps were added to greenprint so that we could trace execution time between steps (aea77ed). GitLab now adds a timestamp to each message in the log, making this unnecessary.

Remove the timestamps from the greenprint, redprint, and yellowprint functions to make the message easier to read, now that the timestamps are redundant.

@achilleas-k
achilleas-k requested a review from a team as a code owner October 8, 2026 08:33
Timestamps were added to greenprint so that we could trace execution
time between steps (aea77ed).  GitLab
now adds a timestamp to each message in the log, making this
unnecessary.

Remove the timestamps from the greenprint, redprint, and yellowprint
functions to make the message easier to read, now that the timestamps
are redundant.
@achilleas-k
achilleas-k force-pushed the test/greenprint-no-time branch from 1096af4 to ea1e302 Compare October 8, 2026 08:33

@avitova avitova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point, thanks!

@achilleas-k
achilleas-k enabled auto-merge (rebase) October 8, 2026 13:38

@brlane-rht brlane-rht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@achilleas-k
achilleas-k merged commit ccc066d into osbuild:main Oct 8, 2026
54 of 57 checks passed
@achilleas-k
achilleas-k deleted the test/greenprint-no-time branch October 8, 2026 15:31
@schutzbot schutzbot added the prod This PR has landed in production. label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prod This PR has landed in production.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants