Repository navigation
cloudapi: add aws-nvidia image type (HMS-11385) - #5269
Merged
Merged
Conversation
Updating osbuild/image-builder osbuild/image-builder@44d5db5 Code changes necessary as the new version adds a 'variant' parameter to bootc.ResolveBootcInfo().
For consistency with the other AWS image types, the image-builder internal type is called ami-nvidia while the cloudapi type is called aws-nvidia. Resolves: HMS-11385
achilleas-k
approved these changes
Oct 12, 2026
achilleas-k
left a comment
Member
There was a problem hiding this comment.
Very nice. Thank you. LGTM!
Member
|
@lfauster I clicked retry a couple of times on the failing RHEL-9-nightly test, but we can ignore it here. It's not related to the PR, nor is it required for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update image-builder to v86, and adapt to minor API changes in image-builder.
Extend openapi to support
aws-nvidiaimage type. For consistency reasons with other AWS images, the image type in composer uses theaws-prefix instead ofami-prefix used in image-builder.