Skip to content

cloudapi: add aws-nvidia image type (HMS-11385) - #5269

Merged
ondrejbudai merged 2 commits into
osbuild:mainfrom
lfauster:add-ami-nvidia-imagetype
Oct 13, 2026
Merged

ondrejbudai merged 2 commits into
osbuild:mainfrom
lfauster:add-ami-nvidia-imagetype

Conversation

@lfauster

@lfauster lfauster commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Update image-builder to v86, and adapt to minor API changes in image-builder.
Extend openapi to support aws-nvidia image type. For consistency reasons with other AWS images, the image type in composer uses the aws- prefix instead of ami- prefix used in image-builder.

Updating osbuild/image-builder
osbuild/image-builder@44d5db5

Code changes necessary as the new version adds a 'variant' parameter
to bootc.ResolveBootcInfo().
For consistency with the other AWS image types, the image-builder internal
type is called ami-nvidia while the cloudapi type is called aws-nvidia.

Resolves: HMS-11385
@lfauster
lfauster requested review from a team and thozza as code owners October 9, 2026 14:40

@achilleas-k achilleas-k left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you. LGTM!

@achilleas-k

achilleas-k commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

@lfauster I clicked retry a couple of times on the failing RHEL-9-nightly test, but we can ignore it here. It's not related to the PR, nor is it required for merging.

@ondrejbudai ondrejbudai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@avitova avitova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks:)

@thozza thozza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ondrejbudai
ondrejbudai merged commit 19ae198 into osbuild:main Oct 13, 2026
56 of 57 checks passed
@schutzbot schutzbot added the prod This PR has landed in production. label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prod This PR has landed in production.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants