Repository navigation
fix(deps): pin every emnapi package to 2.0.0-alpha.6 - #866
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Brooooooklyn
force-pushed
the
fix/emnapi-versions
branch
from
October 19, 2026 04:26
6cf2849 to
411d95b
Compare
Brooooooklyn
force-pushed
the
fix/emnapi-versions
branch
from
October 19, 2026 04:30
411d95b to
4be6a2d
Compare
Brooooooklyn
force-pushed
the
fix/emnapi-versions
branch
from
October 19, 2026 05:42
4be6a2d to
03d19bd
Compare
Brooooooklyn
force-pushed
the
fix/emnapi-versions
branch
from
October 19, 2026 06:59
03d19bd to
e65d975
Compare
#865 moved emnapi and @emnapi/runtime to 2.0.0-beta.2 but left @emnapi/core at 2.0.0-alpha.6, and @napi-rs/cli refuses the mismatch, so the wasm32-wasip1-threads build fails. Moving all three to beta.2 is not the fix: @emnapi/core beta.2 breaks @napi-rs/wasm-runtime 1.2.5, the latest ("Cannot set properties of undefined (setting 'initWorker')"). Pin all three to 2.0.0-alpha.6, as before #865, so a range cannot move one of them alone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/emnapi-versions
branch
from
October 19, 2026 07:03
e65d975 to
63c4d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bottom of stack #867: #861 and #863 build on it, so their CI gets working emnapi versions.
#865 on main moved
emnapiand@emnapi/runtimeto2.0.0-beta.2but left@emnapi/coreat2.0.0-alpha.6.@napi-rs/clirefuses the mismatch, sostable - wasm32-wasip1-threads - node@24fails on main, and the 5 test jobs after it are skipped:Moving all three to beta.2 is not the fix:
@emnapi/corebeta.2 breaks@napi-rs/wasm-runtime1.2.5, the latest, andTest WASI targetfails to load the binding (Cannot set properties of undefined (setting 'initWorker')).So this pins all three to exactly
2.0.0-alpha.6, the versions main used before #865 (where both wasm jobs passed). Move them together once@napi-rs/wasm-runtimesupports emnapi beta.🤖 Generated with Claude Code