Skip to content

fix(no-deprecated): include reasons for variable declarations - #1266

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-deprecated-variable-reasons
Oct 8, 2026
Merged

graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-deprecated-variable-reasons

Conversation

@camc314

@camc314 camc314 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

JSDoc above a variable declaration is attached to its containing statement, so no-deprecated detected the deprecation but omitted its reason. Follow the same ancestor lookup as the checker to include the reason while preserving inline-tag precedence.

Fixes #1265

Copilot AI balanced review requested due to automatic review settings October 8, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T16:17:26.947781Z 4365e00 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@camc314 camc314 added the 0-merge label Oct 8, 2026

camc314 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Merge activity

JSDoc above a variable declaration is attached to its containing statement, so `no-deprecated` detected the deprecation but omitted its reason. Follow the same ancestor lookup as the checker to include the reason while preserving inline-tag precedence.

Fixes #1265
@graphite-app
graphite-app Bot force-pushed the codex/fix-no-deprecated-variable-reasons branch from 4365e00 to 322b385 Compare October 8, 2026 16:38
@graphite-app
graphite-app Bot merged commit 322b385 into main Oct 8, 2026
9 checks passed
@graphite-app graphite-app Bot removed the 0-merge label Oct 8, 2026
@graphite-app
graphite-app Bot deleted the codex/fix-no-deprecated-variable-reasons branch October 8, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no-deprecated: deprecation reason missing for const / let declarations

2 participants