Skip to content

feat(await-thenable): add allowMixedPromiseArrays option - #1307

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/await-thenable-allow-mixed-promise-arrays
Oct 21, 2026
Merged

graphite-app[bot] merged 1 commit into
mainfrom
codex/await-thenable-allow-mixed-promise-arrays

Conversation

@camc314

@camc314 camc314 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Ports typescript-eslint/typescript-eslint#12992.

Adds allowMixedPromiseArrays (default: false) to await-thenable. When enabled, Promise aggregators accept inputs containing at least one potentially Promise-like value, while inputs containing only synchronous values still report diagnostics.

Adds the upstream cases to the existing rule test tables, plus coverage for generic constraints, unknown inputs, thenables, spreads, and the disabled option. Preserves TSGolint's existing diagnostic for string inputs, which upstream currently misses.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T16:20:38.166917Z 61aed71 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

camc314 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Merge activity

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61aed71541

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Ports typescript-eslint/typescript-eslint#12992.

Adds `allowMixedPromiseArrays` (default: `false`) to `await-thenable`. When enabled, Promise aggregators accept inputs containing at least one potentially Promise-like value, while inputs containing only synchronous values still report diagnostics.

Adds the upstream cases to the existing rule test tables, plus coverage for generic constraints, unknown inputs, thenables, spreads, and the disabled option. Preserves TSGolint's existing diagnostic for string inputs, which upstream currently misses.
@graphite-app
graphite-app Bot force-pushed the codex/await-thenable-allow-mixed-promise-arrays branch from 61aed71 to bb8225c Compare October 21, 2026 16:21
@graphite-app graphite-app Bot removed the 0-merge label Oct 21, 2026
@graphite-app
graphite-app Bot merged commit bb8225c into main Oct 21, 2026
8 of 9 checks passed
@graphite-app
graphite-app Bot deleted the codex/await-thenable-allow-mixed-promise-arrays branch October 21, 2026 16:29
graphite-app Bot pushed a commit to oxc-project/oxc that referenced this pull request Oct 23, 2026
…ays` option (#28116)

Add `allowMixedPromiseArrays` to `typescript/await-thenable`, following oxc-project/tsgolint#1307. Oxlint now validates and forwards the option, and exposes it in the JSON schema and TypeScript config types. It defaults to `false`; when enabled, Promise aggregators accept mixed synchronous and Promise-like inputs while synchronous-only inputs still report errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants