Repository navigation
feat(await-thenable): add allowMixedPromiseArrays option - #1307
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merge activity
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61aed71541
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ports typescript-eslint/typescript-eslint#12992. Adds `allowMixedPromiseArrays` (default: `false`) to `await-thenable`. When enabled, Promise aggregators accept inputs containing at least one potentially Promise-like value, while inputs containing only synchronous values still report diagnostics. Adds the upstream cases to the existing rule test tables, plus coverage for generic constraints, unknown inputs, thenables, spreads, and the disabled option. Preserves TSGolint's existing diagnostic for string inputs, which upstream currently misses.
61aed71 to
bb8225c
Compare
…ays` option (#28116) Add `allowMixedPromiseArrays` to `typescript/await-thenable`, following oxc-project/tsgolint#1307. Oxlint now validates and forwards the option, and exposes it in the JSON schema and TypeScript config types. It defaults to `false`; when enabled, Promise aggregators accept mixed synchronous and Promise-like inputs while synchronous-only inputs still report errors.
Ports typescript-eslint/typescript-eslint#12992.
Adds
allowMixedPromiseArrays(default:false) toawait-thenable. When enabled, Promise aggregators accept inputs containing at least one potentially Promise-like value, while inputs containing only synchronous values still report diagnostics.Adds the upstream cases to the existing rule test tables, plus coverage for generic constraints, unknown inputs, thenables, spreads, and the disabled option. Preserves TSGolint's existing diagnostic for string inputs, which upstream currently misses.