Repository navigation
fix(no-deprecated): avoid infinite loop on circular alias chains - #1309
Merged
camc314 merged 1 commit intoOct 21, 2026
Merged
Conversation
camc314
approved these changes
Oct 21, 2026
Contributor
please send an issue/PR upstream. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-deprecatednever finishes when it checks a name whose alias chain is circular. For example:oxlint --type-aware -D typescript/no-deprecated a.ts # hangs foreverThe following cases hang too:
defaultfrom each otherThis PR fixes this issue by stopping the alias walk at the first repeated alias, in the same way as
isSymbolTypeBasedinconsistent-type-exports.typescript-eslint
typescript-eslint has the same loop in
packages/eslint-plugin/src/rules/no-deprecated.ts. Version 8.72.0 also hangs on the file above (with atsconfig.jsonof{}). I have not reported it there yet.AI disclosure
I used an AI coding assistant to find the bug, write the change and the tests, run the checks, and draft this description. I reviewed the change, the results, and this text.