Skip to content

fix(npm): accept TypeScript-aligned versions in the SDK smoke test - #1000

Merged
camc314 merged 1 commit into
mainfrom
fix/sdk-smoke-aligned-version
Nov 16, 2026
Merged

camc314 merged 1 commit into
mainfrom
fix/sdk-smoke-aligned-version

Conversation

@camc314

@camc314 camc314 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The 7.1.0-beta.tsrs1 npm release (run) failed on all four run: true targets at the installed-package smoke test. consumer.mjs still asserted the old <tsrs>-ts<TypeScript> format (/^\d+\.\d+\.\d+.*-ts/) against require("tsrs").version, which #973 changed to 7.1.0-beta.tsrs1. Crates published, so npm never got a TypeScript-aligned version.

The assertion now matches the scheme tools/release/version.mjs validates: a TypeScript version followed by an unpadded tsrsN revision, as in 7.1.0-beta.tsrs1 or 7.1.0-tsrs1. It rejects 0.25.0-ts7.1.0-beta and tsrs0.

Checked against node npm/build.mjs --print-version output. I didn't run the full packed-tarball smoke locally.

@camc314
camc314 added this pull request to stack #1002 November 16, 2026 09:14
@camc314
camc314 marked this pull request as ready for review November 16, 2026 09:15
Copilot AI balanced review requested due to automatic review settings November 16, 2026 09:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: βœ… Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-11-16T09:16:48.228389Z 8885426 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@camc314
camc314 enabled stacked auto-merge November 16, 2026 09:15
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Performance change vs main

Workflow run Β· main e38b23a6446b β†’ PR merge 256a953b3ebd (head 8885426257ad)

Clef gate: Clef estimated 3.6% default and single-threaded wall time, 4.1% peak RSS, 2.9% single-threaded instruction count impact probability.

Benchmarks skipped.

@camc314
camc314 added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 5d58b63 Nov 16, 2026
34 checks passed
@camc314
camc314 deleted the fix/sdk-smoke-aligned-version branch November 16, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants