Repository navigation
fix(npm): accept TypeScript-aligned versions in the SDK smoke test - #1000
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codex Review Summary: β CompletedThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
Performance change vs mainWorkflow run Β· main Clef gate: Clef estimated 3.6% default and single-threaded wall time, 4.1% peak RSS, 2.9% single-threaded instruction count impact probability. Benchmarks skipped. |
The
7.1.0-beta.tsrs1npm release (run) failed on all fourrun: truetargets at the installed-package smoke test.consumer.mjsstill asserted the old<tsrs>-ts<TypeScript>format (/^\d+\.\d+\.\d+.*-ts/) againstrequire("tsrs").version, which #973 changed to7.1.0-beta.tsrs1. Crates published, so npm never got a TypeScript-aligned version.The assertion now matches the scheme
tools/release/version.mjsvalidates: a TypeScript version followed by an unpaddedtsrsNrevision, as in7.1.0-beta.tsrs1or7.1.0-tsrs1. It rejects0.25.0-ts7.1.0-betaandtsrs0.Checked against
node npm/build.mjs --print-versionoutput. I didn't run the full packed-tarball smoke locally.