Skip to content

feat(lint): enable fast mode by default - #989

Merged
camc314 merged 1 commit into
mainfrom
codex/lint-fast-default
Nov 13, 2026
Merged

camc314 merged 1 commit into
mainfrom
codex/lint-fast-default

Conversation

@camc314

@camc314 camc314 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

tsrs-lint and tsrs --lint now enable the fast preset before starting linter workers. TSRS_FAST=0 is the only opt-out; unset, empty, and other values keep it enabled. Per-feature environment overrides still take precedence.

Imported lint baselines and focused startup checks passed. Compiler conformance could not run because the reference test corpus is absent.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 11:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: βœ… Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-11-13T11:47:18.142122Z 071bc9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@camc314
camc314 enabled auto-merge November 13, 2026 11:47
@camc314
camc314 added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 2903e16 Nov 13, 2026
20 checks passed
@camc314
camc314 deleted the codex/lint-fast-default branch November 13, 2026 11:54
@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

βœ… 8 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing codex/lint-fast-default (071bc9b) with main (af46b62)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

Copy link
Copy Markdown
Contributor

Performance change vs main

Workflow run Β· main af46b627897d β†’ PR merge 8f8ae96f9ae6 (head 071bc9b95ede)

Clef gate: Clef estimated 85.1% default and single-threaded wall time, 75.3% peak RSS, 78.8% single-threaded instruction count impact probability.

Release builds in fast mode (TSRS_FAST=1) with Hyperfine 2 hardware counters. After warming each binary, alternating main/PR pairs measure wall time at both the fast preset's default checker count and with --singleThreaded, with ten pairs per configuration by default. Instructions come from the single-threaded runs; peak RSS comes from the default-count runs.
Incremental runs start with fresh build info before every invocation; check runs disable incremental compilation.

Project Mode Single-thread wall time Ξ” Single-thread instructions Ξ” Default wall time Ξ” Default peak RSS Ξ”
vscode check -0.8% 0.000% +1.0% -0.1%
vscode incremental -0.1% +0.001% -0.6% +0.1%
xstate-main check -0.1% 0.000% +0.3% +0.4%
xstate-main incremental +0.6% 0.000% -1.8% -0.2%
webpack check +4.4% +0.001% +1.7% -0.1%
webpack incremental -1.2% +0.005% -0.6% -0.1%
mui-docs check +1.0% +0.007% -1.1% -0.4%
mui-docs incremental -0.7% 0.000% -0.3% +0.5%
Compiler check -2.0% 0.000% -2.4% +0.5%
Compiler incremental +1.3% 0.000% +5.0% +1.1%
Compiler-Unions check -0.5% -0.001% -1.0% +0.8%
Compiler-Unions incremental +6.5% 0.000% -3.3% +0.2%
cal-diy check -0.5% +0.002% +0.3% -0.3%
cal-diy incremental +2.9% +0.002% -1.2% +0.1%
formbricks-web check -0.9% +0.004% +0.2% +0.1%
formbricks-web incremental +1.0% 0.000% +1.4% 0.0%
supabase-studio check -1.6% -0.009% +0.1% 0.0%
supabase-studio incremental +0.5% -0.003% +0.1% +0.2%
t3code-server check +0.2% +0.003% +0.2% +0.5%
t3code-server incremental -5.7% -0.007% +1.6% -0.1%
mikro-orm check +0.5% +0.003% +0.4% -0.1%
mikro-orm incremental +0.9% +0.001% +2.7% +0.1%
next-packages-next check -0.5% 0.000% -2.9% -1.2%
next-packages-next incremental -0.4% +0.002% -0.4% -0.3%
next-root check +0.7% -0.001% -1.6% 0.0%
next-root incremental -0.3% 0.000% -0.5% +0.4%
storybook check +0.2% +0.001% +1.3% -0.7%
storybook incremental -0.4% +0.008% +2.2% +0.2%
nuxt check -0.1% +0.003% -3.4% -0.1%
nuxt incremental -0.2% -0.004% -1.9% -0.5%
playwright check -1.5% +0.001% +4.6% +1.3%
playwright incremental -0.6% 0.000% -1.4% -0.2%
drizzle-orm check +0.6% -0.007% +0.7% -1.4%
drizzle-orm incremental -0.1% -0.004% +0.1% -0.1%
typeorm check +1.5% +0.002% -0.9% -0.6%
typeorm incremental +0.9% +0.003% +1.0% +0.3%
date-fns check +2.0% +0.020% +2.6% -0.3%
date-fns incremental +0.2% +0.001% +1.4% +0.7%

Negative means the PR used less; positive means it used more. Deltas are medians of paired PR/main ratios for wall time and instructions. Single-threaded runs reduce scheduling noise; shared CI machines can still add noise to wall time.

Measured medians (main β†’ PR)
Project Mode Single-thread wall time (s) Single-thread instructions Default wall time (s) Default peak RSS (MiB)
vscode check 9.201 β†’ 9.954 82,406,233,079.5 β†’ 82,406,176,161.5 1.435 β†’ 1.449 1844.8 β†’ 1843.2
vscode incremental 11.139 β†’ 10.174 84,821,631,720 β†’ 84,821,759,681.5 1.668 β†’ 1.674 2161.2 β†’ 2162.7
xstate-main check 0.528 β†’ 0.529 5,570,741,738 β†’ 5,570,771,358 0.137 β†’ 0.136 241.2 β†’ 242.0
xstate-main incremental 0.559 β†’ 0.574 5,733,647,920 β†’ 5,733,674,881.5 0.181 β†’ 0.180 244.4 β†’ 243.9
webpack check 0.987 β†’ 1.033 10,899,960,561.5 β†’ 10,900,043,365 0.207 β†’ 0.208 404.3 β†’ 403.8
webpack incremental 1.102 β†’ 1.082 11,123,821,316.5 β†’ 11,124,319,616.5 0.249 β†’ 0.249 402.5 β†’ 402.1
mui-docs check 2.637 β†’ 2.660 33,126,310,441.5 β†’ 33,127,809,698 0.998 β†’ 0.996 1234.9 β†’ 1230.3
mui-docs incremental 2.537 β†’ 2.518 34,466,068,271.5 β†’ 34,466,738,375.5 1.099 β†’ 1.101 1161.5 β†’ 1167.1
Compiler check 0.157 β†’ 0.151 1,776,342,215.5 β†’ 1,776,336,970 0.065 β†’ 0.065 76.9 β†’ 77.3
Compiler incremental 0.167 β†’ 0.168 1,789,151,842 β†’ 1,789,145,651.5 0.075 β†’ 0.078 79.2 β†’ 80.0
Compiler-Unions check 0.196 β†’ 0.196 3,054,469,992.5 β†’ 3,054,446,989.5 0.091 β†’ 0.090 80.6 β†’ 81.2
Compiler-Unions incremental 0.314 β†’ 0.329 3,066,300,460.5 β†’ 3,066,299,241 0.111 β†’ 0.110 84.5 β†’ 84.7
cal-diy check 2.646 β†’ 2.619 28,973,505,609 β†’ 28,974,739,645 0.863 β†’ 0.858 1363.8 β†’ 1359.8
cal-diy incremental 3.720 β†’ 3.897 30,595,413,272 β†’ 30,595,312,038 1.210 β†’ 1.205 1267.4 β†’ 1268.2
formbricks-web check 3.556 β†’ 3.538 37,109,686,877.5 β†’ 37,111,210,033.5 0.901 β†’ 0.899 1586.0 β†’ 1587.9
formbricks-web incremental 5.035 β†’ 5.071 39,709,092,356.5 β†’ 39,709,547,556.5 1.630 β†’ 1.632 1624.9 β†’ 1625.0
supabase-studio check 3.881 β†’ 3.877 40,844,623,883 β†’ 40,841,137,311.5 1.081 β†’ 1.097 1311.1 β†’ 1311.0
supabase-studio incremental 3.900 β†’ 3.917 43,793,234,272 β†’ 43,790,672,905 1.049 β†’ 1.050 1365.6 β†’ 1368.9
t3code-server check 3.727 β†’ 3.741 41,107,938,120.5 β†’ 41,109,323,836.5 1.569 β†’ 1.580 1444.7 β†’ 1452.4
t3code-server incremental 4.480 β†’ 4.680 41,632,559,216 β†’ 41,629,526,805.5 1.443 β†’ 1.473 1311.1 β†’ 1309.3
mikro-orm check 4.533 β†’ 4.467 44,563,032,819 β†’ 44,564,241,060 0.866 β†’ 0.867 1282.8 β†’ 1281.7
mikro-orm incremental 4.879 β†’ 4.925 44,875,687,939.5 β†’ 44,875,483,118.5 1.292 β†’ 1.307 1256.6 β†’ 1258.5
next-packages-next check 1.934 β†’ 1.926 17,410,325,526 β†’ 17,410,307,698.5 0.408 β†’ 0.399 564.5 β†’ 557.8
next-packages-next incremental 1.527 β†’ 1.529 17,736,107,762.5 β†’ 17,736,253,167.5 0.579 β†’ 0.562 564.2 β†’ 562.7
next-root check 1.236 β†’ 1.241 13,969,316,071 β†’ 13,969,117,109 0.315 β†’ 0.300 432.7 β†’ 432.8
next-root incremental 1.407 β†’ 1.390 14,431,267,548.5 β†’ 14,431,147,652.5 0.366 β†’ 0.367 472.2 β†’ 473.9
storybook check 0.844 β†’ 0.831 8,875,559,261.5 β†’ 8,875,605,332.5 0.210 β†’ 0.215 400.4 β†’ 397.8
storybook incremental 1.368 β†’ 1.317 9,200,582,298 β†’ 9,201,051,850 0.310 β†’ 0.310 376.4 β†’ 377.3
nuxt check 0.958 β†’ 0.959 8,506,903,109.5 β†’ 8,507,113,551.5 0.242 β†’ 0.232 391.1 β†’ 390.6
nuxt incremental 0.867 β†’ 0.869 8,909,587,244 β†’ 8,909,246,140 0.231 β†’ 0.228 393.7 β†’ 391.8
playwright check 0.713 β†’ 0.701 7,408,230,332.5 β†’ 7,408,300,154 0.180 β†’ 0.185 358.1 β†’ 362.8
playwright incremental 0.710 β†’ 0.712 7,581,516,484.5 β†’ 7,581,599,984 0.202 β†’ 0.208 339.6 β†’ 338.9
drizzle-orm check 0.527 β†’ 0.530 5,952,912,462 β†’ 5,952,732,369 0.177 β†’ 0.180 384.0 β†’ 378.7
drizzle-orm incremental 0.596 β†’ 0.595 6,124,196,914.5 β†’ 6,124,246,501.5 0.189 β†’ 0.186 345.2 β†’ 344.7
typeorm check 0.642 β†’ 0.658 6,399,986,922 β†’ 6,400,052,018.5 0.145 β†’ 0.143 226.2 β†’ 224.9
typeorm incremental 0.658 β†’ 0.669 6,777,646,880.5 β†’ 6,777,894,218.5 0.170 β†’ 0.168 231.6 β†’ 232.3
date-fns check 0.321 β†’ 0.318 3,356,792,691.5 β†’ 3,357,191,334.5 0.091 β†’ 0.093 152.1 β†’ 151.7
date-fns incremental 0.344 β†’ 0.345 3,593,755,272.5 β†’ 3,593,725,550.5 0.162 β†’ 0.165 161.5 β†’ 162.5

tsrs-lint

Release tsrs-lint linting each project's source files with all 61 rules. After a warmup run of each binary, alternating main/PR pairs (10 per mode) measure wall time, CPU time and peak RSS with TSRS_FAST unset and with TSRS_FAST=1.

Project Mode Wall time Ξ” CPU time Ξ” Peak RSS Ξ” Diagnostics (main β†’ PR)
webpack default -33.0% +8.0% +6.0% 37258, identical
webpack TSRS_FAST=1 -0.9% -1.3% +0.1% 37258, identical
drizzle-orm default -37.2% +2.9% -8.4% 7057, identical
drizzle-orm TSRS_FAST=1 -1.5% -1.0% 0.0% 7057, identical
xstate-main default -20.0% +2.2% -5.3% 6489, identical
xstate-main TSRS_FAST=1 +2.0% +0.5% 0.0% 6489, identical

Negative means the PR used less. Wall and CPU time deltas are medians of paired PR/main ratios; peak RSS compares medians.

Measured lint medians (main β†’ PR)
Project Mode Wall time (s) CPU time (s) Peak RSS (MiB)
webpack default 0.588 β†’ 0.393 1.867 β†’ 2.013 440.9 β†’ 467.2
webpack TSRS_FAST=1 0.395 β†’ 0.384 2.014 β†’ 1.992 466.8 β†’ 467.5
drizzle-orm default 0.388 β†’ 0.253 1.275 β†’ 1.352 440.8 β†’ 403.9
drizzle-orm TSRS_FAST=1 0.256 β†’ 0.243 1.345 β†’ 1.297 404.2 β†’ 404.2
xstate-main default 0.413 β†’ 0.335 1.429 β†’ 1.443 362.1 β†’ 343.0
xstate-main TSRS_FAST=1 0.329 β†’ 0.333 1.445 β†’ 1.474 342.4 β†’ 342.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants