Repository navigation
fix(lint): report type errors only for linted files - #998
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codex Review Summary: β CompletedThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab16c08d46
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
cc @maschwenk i need to change this else it's not really a drop-in releacement for tsgolint. I think users might want some more fine grained controls over this which we'll address as feedback comes in. |
Performance change vs mainWorkflow run Β· main Clef gate: Running benchmarks because the decision was unavailable (crates/tsrs_lint/src/engine.rs: patch exceeds the Clef context limit (10623 bytes)). Release builds in fast mode (TSRS_FAST=1) with Hyperfine 2 hardware counters. After warming each binary, alternating main/PR pairs measure wall time at both the fast preset's default checker count and with --singleThreaded, with ten pairs per configuration by default. Instructions come from the single-threaded runs; peak RSS comes from the default-count runs.
Negative means the PR used less; positive means it used more. Deltas are medians of paired PR/main ratios for wall time and instructions. Single-threaded runs reduce scheduling noise; shared CI machines can still add noise to wall time. Measured medians (main β PR)
tsrs-lintRelease
Negative means the PR used less. Wall and CPU time deltas are medians of paired PR/main ratios; peak RSS compares medians. Measured lint medians (main β PR)
|
Merging this PR will degrade performance by 4.19%1 warning
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
ab16c08 to
138b08d
Compare
oxlint --type-checknow reports compiler diagnostics only for the files Oxlint selected for linting, as tsgolint does. Since #930, tsrs also reported diagnostics from other eligible files in each loaded TypeScript program, so files excluded by Oxlint ignore patterns, CLI path selection ortsconfig.excludecould still fail lint when they were part of the TypeScript program.Other program files still provide type information. Listed files outside every tsconfig are still checked in an inferred program. Program-wide global diagnostics are no longer reported on the tsconfig because they do not belong to a linted file; this also matches tsgolint's file-level reporting.
The diagnostic-scope reproduction now matches tsgolint in all six cases.
Context: voidzero-dev/vite-plus#3352 (comment)