Repository navigation
Document all unstable API features in README - #1094
Merged
Merged
Conversation
The Unstable API section only mentioned Parser, but the unstable package also exports the Marshaler/Unmarshaler interfaces and RawMessage, so users browsing the README could not discover them. List them all, and add a note to AGENTS.md so the list stays in sync when unstable features are added, promoted, or removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The coverage CI job compares total coverage of the PR against v2 and fails on any decrease. Whether arrayCount's nil-map fast path executes depends on decoder pooling: a decoder reused from the sync.Pool keeps its arrayCounts map allocated across documents, so the branch is only hit when an array table is decoded by a fresh decoder, which varies with GC timing and test scheduling. This made the job flake (97.6% vs 97.7%) on PRs that do not touch any Go code. Cover the nil-map paths of arrayCount, setArrayCount and resetChildArrayCounts deterministically with a direct test on a fresh decoder. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Unstable API" section of the README only mentioned
Parser, but theunstablepackage also exports theMarshaler/Unmarshalerinterfaces (opt-in viaEncoder.EnableMarshalerInterface/Decoder.EnableUnmarshalerInterface) andRawMessage. Users browsing the README could not discover them.RawMessage, with pkg.go.dev links, matching the existing style. The AST types (Node,Iterator,Kind, โฆ) remain covered by theParserentry.unstablepackage and be updated in the same change that adds, promotes, or removes one.๐ค Generated with Claude Code