Skip to content

Stabilize non-conformant WHEEL Tag metadata. - #2927

Merged
jsirois merged 2 commits into
pex-tool:mainfrom
jsirois:issues/2926
Oct 7, 2025
Merged

jsirois merged 2 commits into
pex-tool:mainfrom
jsirois:issues/2926

Conversation

@jsirois

@jsirois jsirois commented Oct 7, 2025

Copy link
Copy Markdown
Member

This fixes --venv-repository resolution to synthesize consistent wheel
file names in the face of non-conformant WHEEL Tag metadata containing
compressed tags instead of expanded tags.

Fixes #2926

This fixes `--venv-repository` resolution to synthesize consistent wheel
file names in the face of non-conformant WHEEL Tag metadata containing
compressed tags instead of expanded tags.

Fixes pex-tool#2926
# `cp37-abi3-manylinux_2_17_x86_64` and `cp37-abi3-manylinux2014_x86_64` which is right, but
# only up to ordering, which is unstable. We sort the tags to stabilize which results in the
# `manylinux2014_x86_64` platform tag now coming 1st unlike in the original wheel.
assert "hf-xet-1.1.10-cp37-abi3-manylinux2014_x86_64.manylinux_2_17_x86_64.whl" in path.split(

@jsirois jsirois Oct 7, 2025 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the fix, this assertion would fail some percentage of the time; it now passes every time.

@jsirois
jsirois merged commit 83cef00 into pex-tool:main Oct 7, 2025
@jsirois
jsirois deleted the issues/2926 branch October 7, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File name lookup issue when using --venv-repository

1 participant