Repository navigation
test: cover config settings forwarding in build_package and build_package_via_sdist - #1058
Merged
gaborbernat merged 6 commits intoMay 29, 2026
Merged
Conversation
terminalchai
requested review from
FFY00,
gaborbernat,
henryiii and
layday
as code owners
May 7, 2026 19:08
terminalchai
added a commit
to terminalchai/build
that referenced
this pull request
May 9, 2026
Contributor
|
@terminalchai can you fix the CI and also the merge conflict? |
gaborbernat
marked this pull request as draft
May 28, 2026 14:37
for more information, see https://pre-commit.ci
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
terminalchai
force-pushed
the
test/config-settings-coverage
branch
from
May 28, 2026 20:38
d2689c8 to
5d72702
Compare
gaborbernat
approved these changes
May 29, 2026
gaborbernat
marked this pull request as ready for review
May 29, 2026 22:36
Member
|
It looks like nothing's been changed here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build_packageandbuild_package_via_sdistboth accept aconfig_settingsparameter and forward it to_build, but there were no tests verifying that this forwarding actually happens. A refactor that silently droppedconfig_settingsfrom the_buildcall would pass the existing test suite.Fix
Add two unit tests:
test_build_package_passes_config_settings_to_build— callsbuild_packagewithconfig_settings={'--flag': 'value'}and asserts both thesdistandwheel_buildcalls receive the settings in the correct position.test_build_package_via_sdist_passes_config_settings_to_build— same forbuild_package_via_sdist, also covering thesdist→wheeltwo-step flow (temp dir creation, extraction, cleanup).Both tests also cover the other recently-added parameters (
dependency_constraints_txt,installer) to make the call signatures explicit.