Repository navigation
chore: default --installer to pip in argparse - #1117
Merged
Merged
Conversation
The `_Args` stub already claimed `installer: _env.Installer | None` was a `Literal['pip', 'uv']`, but argparse left it unset (`None`) until `main()` checked `== 'uv'`. Set `default='pip'` explicitly so the type matches runtime behavior. Assisted-by: ClaudeCode:claude-sonnet-5
Assisted-by: ClaudeCode:claude-sonnet-5
henryiii
marked this pull request as ready for review
July 2, 2026 13:55
layday
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it was this way because we were thinking to add a smart default that would use either? That never happened, so this seem fine and simpler to check.
🤖 AI text below 🤖
Summary
--installerhad nodefault, soargs.installerwasNoneat runtime even though it's typed as_env.Installer(Literal['pip', 'uv']) everywhere downstream. It only worked because callers just checked== 'uv'.default='pip'on the argparse option (matching the existing help text "defaults to pip") and tighten the_Argsstub annotation from_env.Installer | Noneto_env.Installer.tests/test_main.pyassertions/defaults that previously expectedinstallerto beNone.Part of the code review in #1116.