Skip to content

tests: fix tox min job - #870

Merged
henryiii merged 4 commits into
pypa:mainfrom
henryiii:henryiii/fix/tox
Mar 7, 2025
Merged

henryiii merged 4 commits into
pypa:mainfrom
henryiii:henryiii/fix/tox

Conversation

@henryiii

@henryiii henryiii commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Tests have been broken on main for a bit. See if it can be fixed.

@henryiii
henryiii force-pushed the henryiii/fix/tox branch 3 times, most recently from bec0763 to 759bb82 Compare March 6, 2025 23:17
@henryiii
henryiii force-pushed the henryiii/fix/tox branch 2 times, most recently from a8a6492 to 8b5c6b4 Compare March 7, 2025 15:47
@layday

layday commented Mar 7, 2025

Copy link
Copy Markdown
Member

I can't tell right now cuz all the tests are failing, but switching from pytest-cov to coverage will reduce coverage if we've got any tests running in subprocesses, unless we set up implicit coverage.

@henryiii

henryiii commented Mar 7, 2025 •

Copy link
Copy Markdown
Contributor Author

I was just trying to solve the "no coverage" found issue on the min jobs (first commit). Looks like pytest-xdist might cause problems too. Okay, let's just try to fix pytest-cov.

henryiii added 3 commits March 7, 2025 13:01
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii force-pushed the henryiii/fix/tox branch 6 times, most recently from b0f4524 to 3d3f429 Compare March 7, 2025 20:14
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii

henryiii commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

Okay, working, here's a summary of the changes:

Min version test:

  • Pinned setuptools_scm for older Pythons as it now errors out with old setuptools
  • Increased the pin on packaging on older pythons to make setuptools_scm happy
  • Used a simpler way to set the constraints in tox but still have them cleared for subprocess calls

I also had to remove the error on coverage combine, as it errors out when there's nothing to combine, and that happens on the min version test since we only do one run in CI.

I also added pip to the deps, as it's required when using tox-uv (which is what I'm using locally).

@henryiii

henryiii commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

I think there's an issue with threading where setuptools may fight over the same source directory from multiple threads, causing an occasional error we've seen for a while. But not fixing that here.

@henryiii
henryiii merged commit 2bb342b into pypa:main Mar 7, 2025
@henryiii
henryiii deleted the henryiii/fix/tox branch March 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants