Skip to content

feat: drop Python 3.8 - #891

Merged
henryiii merged 2 commits into
pypa:mainfrom
henryiii:henryiii/feat/drop38
May 14, 2025
Merged

henryiii merged 2 commits into
pypa:mainfrom
henryiii:henryiii/feat/drop38

Conversation

@henryiii

@henryiii henryiii commented May 6, 2025

Copy link
Copy Markdown
Contributor

Dropping 3.8.

@henryiii
henryiii marked this pull request as draft May 6, 2025 14:46
@henryiii

henryiii commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

We need to remove --no-wheel and make a patch release before we can drop 3.8, since the virtualenv that produces a warning with --no-wheel was released for 3.8. Will keep on draft till then.

@henryiii

henryiii commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

Actually, I'm not sure that's true, since 3.8 still has wheel, so it should not trigger the warning. We probably can drop at the same time.

@henryiii henryiii mentioned this pull request May 6, 2025
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii force-pushed the henryiii/feat/drop38 branch from 09f7a7b to b3c6282 Compare May 14, 2025 00:57
@henryiii
henryiii marked this pull request as ready for review May 14, 2025 01:09
@henryiii
henryiii merged commit 932c54e into pypa:main May 14, 2025
@henryiii
henryiii deleted the henryiii/feat/drop38 branch May 14, 2025 01:17
@jayaddison

Copy link
Copy Markdown
Contributor

Hi @henryiii - a question, and maybe an opportunity related to this pull request: could/should usage of pypy38 also be removed following the removal of Py3.8?

There are at least a couple of references to it remaining in the codebase currently; e.g.

build/tox.ini

Line 11 in 14aecb1

{py314, py313, py312, py311, py310, py39, pypy314, pypy310, pypy39, pypy38}{, -min}

@henryiii

henryiii commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Yes. Technically pypy3.11 is the only non-EoL PyPy now, but it's easier to match since there isn't a way to maps python-requires depend on the Python implementation. But yes, pypy3.8 should not be present!

@jayaddison

Copy link
Copy Markdown
Contributor

Ok, thanks!

Wwould you welcome a pull request with that cleanup (note/clarification: only the removal of pypy38 occurrences), or should I leave that to you and/or other maintainers?

@henryiii

henryiii commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Sure. :) If you want to add pypy3.11 while you are at it, you can, but fine if you want to leave that up to us eventually, too.

@jayaddison

Copy link
Copy Markdown
Contributor

Great, OK. I'll offer an advancement of the PyPy versions, in that case (removing pypy38 and introducing pypy311 in step).

It also seems to me that we can remove the pypy3323 bug workarounds -- because the earliest version supporting the Python 3.11 runtime appears to be PyPy v7.3.11 -- and that exceeds the v7.3.9 version precondition to avoid the bug (please double-check me on that if you have time, though).

@jayaddison

Copy link
Copy Markdown
Contributor

Ah; my mistake - because PyPy v3.9 is still supported, there are some older runtime versions of that could be affected by the pypy3323 bug -- e.g. pypy3.9-v7.3.8-win64.zip.

@henryiii

henryiii commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

If there's any version with 3.9 that is fine (pypy3.9-v7.3.16?), I'd be tempted to simply say that we don't support anything older than whatever that version is (7.3.16 or 7.3.11?). People should not be using old PyPy versions that are unsupported; if we can say "please update to 7.3.16 to fix the bug", I think that's fine. Depends on the opinion of other maintainers, though.

henryiii pushed a commit that referenced this pull request Aug 5, 2025
…924)

* chore: drop PyPi v3.8

Follow-up to #891

* tox: add `pypy311` to `env_list` matrix

Ref: #891 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants