Skip to content

Add quiet flag - #947

Merged
gaborbernat merged 4 commits into
pypa:mainfrom
layday:feat-quiet-flag
Dec 12, 2025
Merged

gaborbernat merged 4 commits into
pypa:mainfrom
layday:feat-quiet-flag

Conversation

@layday

@layday layday commented Nov 1, 2025

Copy link
Copy Markdown
Member

No description provided.

@layday layday linked an issue Nov 1, 2025 that may be closed by this pull request
Comment thread src/build/__main__.py Outdated

def log(message: str, *, origin: tuple[str, ...] | None = None) -> None:
if _ctx.verbosity < 0:
return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line never gets tested, are you thinking of adding a test?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I haven't added any tests yet.

@layday

layday commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

I wonder if we should add two quietness levels, -q and -qq. The first suppresses subprocess (build backend) output, the second suppresses all output. WDYT?

@henryiii

Copy link
Copy Markdown
Contributor

I like that idea, personally; cibuildwheel will be able to select from multiple levels too. Though I wasn't sure which was more useful to suppress, our output or the build-backend output. Maybe three levels, -q suppresses our output, -qq suppresses the build backend, and -qqq surpasses both? Sort of assuming build backends will always be noisier than our output there. Though I'm fine with the two level approach. Not sure filtering out our output only would ever be needed.

@henryiii

henryiii commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Might be good to get a release out. Do you think this could be finished soon?

@layday

layday commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

I'll try to get to it mid-week.

@layday
layday force-pushed the feat-quiet-flag branch 2 times, most recently from 79593ae to abbd3d9 Compare December 12, 2025 12:15
@layday
layday marked this pull request as ready for review December 12, 2025 12:33
@layday
layday requested a review from henryiii December 12, 2025 12:34
@gaborbernat
gaborbernat merged commit 0e44fd2 into pypa:main Dec 12, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verbosity flag

3 participants