Skip to content

GC crash in subtype_dealloc when inherting from _multiprocessing.SemLockΒ #94736

Closed

Description

@kumaraditya303

Crash report

GC crash in subtype_dealloc when inherting from _multiprocessing.SemLock.

Reproducer (read carefully before running!):

from _multiprocessing import SemLock
class S(SemLock):
    pass


s = S(1, 1, 2, 'foo', 1)

Error messages

@kumaraditya303 ➜ /workspaces/cpython (main βœ—) $ ./python main.py 
Segmentation fault (core dumped)

GDB backtrace:

#0  _PyObject_GC_UNTRACK (op=<S() at remote 0x7ffff778d480>, lineno=2242, 
    filename=0x5555559ae5dc "Modules/gcmodule.c") at ./Include/internal/pycore_object.h:174
#1  PyObject_GC_UnTrack (op_raw=0x7ffff778d480) at Modules/gcmodule.c:2242
#2  0x0000555555760e71 in subtype_dealloc (self=<S() at remote 0x7ffff778d480>)
    at Objects/typeobject.c:1368
#3  0x0000555555742e85 in _Py_Dealloc (op=<optimized out>) at Objects/object.c:2382
#4  0x0000555555726b1b in Py_DECREF (op=<optimized out>, lineno=609, 
    filename=0x55555591d5dd "./Include/object.h") at ./Include/object.h:533
#5  Py_XDECREF (op=<optimized out>) at ./Include/object.h:609
#6  free_keys_object (keys=keys@entry=0x7ffff777cf70) at Objects/dictobject.c:664
#7  0x0000555555727258 in dictkeys_decref (dk=0x7ffff777cf70) at Objects/dictobject.c:324
#8  dict_dealloc (mp=0x7ffff772d490) at Objects/dictobject.c:2378
#9  0x0000555555742e85 in _Py_Dealloc (op=<optimized out>) at Objects/object.c:2382
#10 0x000055555573f7e9 in Py_DECREF (op=<optimized out>, lineno=609, 
    filename=0x55555591d5dd "./Include/object.h") at ./Include/object.h:533
#11 Py_XDECREF (op=<optimized out>) at ./Include/object.h:609
#12 module_dealloc (m=0x7ffff772da30) at Objects/moduleobject.c:699
#13 0x0000555555742e85 in _Py_Dealloc (op=<optimized out>) at Objects/object.c:2382
#14 0x000055555572bca7 in Py_DECREF (op=<optimized out>, lineno=609, 

Your environment

  • CPython versions tested on: Python 3.12.0a0 da71751, Python 3.11.0b3+ f3212b1 on linux
  • Operating system and architecture: Linux 5.4.0-1074-azure x86_64

cc @pablogsal

Activity

  1. encukou commented on Jul 11, 2022

    @encukou
    Member

    Whoah, is the rm -rf /dev/shm/* necessary to reproduce? I've added a warning to the reproducer, since this can break more than Python.

    Not that this shouldn't be fixed if it's easy to fix, but a crash is just what I'd expect when messing around with shared memory files directly.

  2. pablogsal commented on Jul 11, 2022

    @pablogsal
    Member

    @kumaraditya303 Thanks a lot for raising the issue :)

    One small note: please, don't mark everything as release blocker just because it crashes. In this case, the reproducer involves non standard actions (deleting the shared memory segment) so is not that critical to block releases.

    Also, as this issue affects old versions it should not block 3.11.

  3. kumaraditya303 commented on Jul 11, 2022

    @kumaraditya303
    ContributorAuthor

    Whoah, is the rm -rf /dev/shm/* necessary to reproduce?

    It makes debugging easier otherwise you would have change the name of semlock everytime as the interpreter crashes to avoid OSErrors, removed now.

  4. kumaraditya303 commented on Jul 11, 2022

    @kumaraditya303
    ContributorAuthor

    One small note: please, don't mark everything as release blocker just because it crashes. In this case, the reproducer involves non standard actions (deleting the shared memory segment) so is not that critical to block releases.

    Deleting the shared memory segment isn't necessary it was just to aid debugging which I removed now. Regarding release blocker, this issue was part of a bigger problem which I haven't been able to create a minimal reproducer for involving Py_TPFLAGS_MANAGED_DICT not creating dictionary properly but I was getting this segfault. It's up to you to consider this release blocker or not as I am not the release manager :)

  5. kumaraditya303 commented on Jul 11, 2022

    @kumaraditya303
    ContributorAuthor

    See #94738

  6. 4 remaining items

  7. added 6 commits that reference this issue on Jul 11, 2022
  8. tiran commented on Jul 11, 2022

    @tiran
    Member

    SemLock can also fail on Linux, see skip_if_broken_multiprocessing_synchronize helper method.

  9. reopened this on Jul 11, 2022
  10. added a commit that references this issue on Jul 11, 2022
  11. kumaraditya303 commented on Jul 11, 2022

    @kumaraditya303
    ContributorAuthor

    SemLock can also fail on Linux, see skip_if_broken_multiprocessing_synchronize helper method.

    Feel free to propose a PR.

  12. added a commit that references this issue on Jul 11, 2022
  13. pablogsal commented on Jul 11, 2022

    @pablogsal
    Member

    SemLock can also fail on Linux, see skip_if_broken_multiprocessing_synchronize helper method.

    The tests are skipped in that case as there is a global support.skip_if_broken_multiprocessing_synchronize call in the test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

3.10 (EOL)end of life3.11only security fixes3.12only security fixestype-crashA hard crash of the interpreter, possibly with a core dump

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions