You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
AIX build failing because of python.exp not being created before building shared modules. ย #96269
AIX build is failing with the main branch. The error thrown is "Modules/python.exp" file not found while building the shared modules. In AIX, the export file is required for the creation of shared modules.
So the "sharedmods" target needs "EXPORTSYMS" target to be built before so that the export file is created before building the shared modules.
The fix didn't work actually. It introduced a circular dependency and the creation of libpython3.12.a didn't happen, so it ended up creating a empty python.exp file.
Activity
pythongh-96269: Fix build dependency on AIX
gh-96269: Fix build dependency on AIX (GH-96304)
tiran commentedon Aug 26, 2022
Problem is fixed in main branch.
ayappanec commentedon Aug 26, 2022
The fix didn't work actually. It introduced a circular dependency and the creation of libpython3.12.a didn't happen, so it ended up creating a empty python.exp file.
https://buildbot.python.org/all/#/builders/438/builds/3413/steps/3/logs/stdio
gmake: Circular Modules/python.exp <- libpython3.12.a dependency dropped.
./Modules/makexp_aix Modules/python.exp "."
I already have working fix for the original issue. Planning to create a PR.
@tiran Can you revert the changes ?
pythongh-96269: static and shared ext need different deps
tiran commentedon Aug 26, 2022
Does #96316 work for you?
ayappanec commentedon Aug 27, 2022
The above works.
But I have created a fix like this
Let me know your opinion about my fix.
ayappanec commentedon Aug 30, 2022
#96316 also considers the static build of the modules case (where EXPORTSYMS is not required).
So I think we can go ahead with #96316.
ayappanec commentedon Sep 1, 2022
@tiran Can #96316 be merged? . This will fix one of the two build issues in AIX.
ayappanec commentedon Sep 2, 2022
@tiran
ayappanec commentedon Oct 26, 2022
Can this be merged please ?
gh-96269: static and shared ext need different deps (#96316)