Repository navigation
[ci] fix Flight npm validation and check browser cache hits - #38122
Merged
Merged
Conversation
|
No build was found for the base commit (ce01166) that this pull request diverged from, so there is no size report. The build for that commit may have failed, or its artifacts may be older than the retention window. Rebase the pull request onto a newer Generated by sizebot against 18349df |
eps1lon
approved these changes
Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Flight fixture CI failure after #38104:
npx playwright install --with-deps chromiumfails withInvalid property "devEngines.node". Use npm's supporteddevEngines.runtimeschema and allow the Node 20 and 24 versions tested by CI.The final PR's Node 24 job restored the browser cache and skipped installation; the main job missed that cache and exposed the error. Both used Node 24.22.1 and npm 11.19.1.
Run
npx --offline playwright --versionbefore looking up the browser cache so npm validates the fixture even on cache hits. Keep browser and system dependency installation conditional to avoid adding that work to every run. Also isolate Flight browser caches by Node configuration and.nvmrcso each configuration exercises installation after a Node update.How did you test this change?
npx --offline playwright --versionsucceeds with the fix and fails with the original package.json, using the same installed dependencies.json-stringify) andgit diff --checkpass. Full Linux CI has not run locally.