Skip to content

[ci] fix Flight npm validation and check browser cache hits - #38122

Merged
eps1lon merged 1 commit into
react:mainfrom
kassens:kassens/fix-flight-npm-validation
Nov 5, 2026
Merged

eps1lon merged 1 commit into
react:mainfrom
kassens:kassens/fix-flight-npm-validation

Conversation

@kassens

@kassens kassens commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the Flight fixture CI failure after #38104: npx playwright install --with-deps chromium fails with Invalid property "devEngines.node". Use npm's supported devEngines.runtime schema and allow the Node 20 and 24 versions tested by CI.

The final PR's Node 24 job restored the browser cache and skipped installation; the main job missed that cache and exposed the error. Both used Node 24.22.1 and npm 11.19.1.

Run npx --offline playwright --version before looking up the browser cache so npm validates the fixture even on cache hits. Keep browser and system dependency installation conditional to avoid adding that work to every run. Also isolate Flight browser caches by Node configuration and .nvmrc so each configuration exercises installation after a Node update.

How did you test this change?

  • Reproduced the original npm validation error and confirmed the corrected schema accepts Node 20.19.0 and 24.22.1.
  • Verified npx --offline playwright --version succeeds with the fix and fails with the original package.json, using the same installed dependencies.
  • Timed five version checks on macOS with Node 24.22.1/npm 11.19.1: median 0.327 seconds. This measures the validation check, not Linux system dependency installation.
  • Parsed the workflow YAML and checked that npm validation is unconditional while browser installation remains conditional.
  • Package JSON formatting (json-stringify) and git diff --check pass. Full Linux CI has not run locally.

@meta-cla meta-cla Bot added the CLA Signed label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

No build was found for the base commit (ce01166) that this pull request diverged from, so there is no size report. The build for that commit may have failed, or its artifacts may be older than the retention window. Rebase the pull request onto a newer main to compare against a base commit that has a build.

Generated by sizebot against 18349df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants