Skip to content

test-frames-depth modified to work in front of wall - #14497

Merged
OhadMeir merged 4 commits into
realsenseai:migrationfrom
remibettan:test-depth-wall
Dec 9, 2025
Merged

OhadMeir merged 4 commits into
realsenseai:migrationfrom
remibettan:test-depth-wall

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

No description provided.

@remibettan
remibettan requested a review from AviaAv December 8, 2025 10:44
@remibettan
remibettan requested a review from OhadMeir December 9, 2025 08:37
fill_rate = 100.0 * (total - num_blank_pixels) / total if total > 0 else 0
log.i(f"Depth fill rate: {fill_rate:.1f}% (blank pixels: {num_blank_pixels}/{total}), meaningful depth: {meaningful_depth} (largest bin: {max_nonzero_percent:.1f}% - max allowed {DEPTH_PERCENTAGE * 100:.1f}%)")
return meaningful_depth, num_blank_pixels
fill_rate_ok = fill_rate > (1 - BLACK_PIXEL_THRESHOLD) * 100.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be OK if fill rate > 20%. Seems a bit low. I think should be at least 50

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

# we check a few different frames to try and detect depth
for frame_num in range(FRAMES_TO_CHECK):
has_depth, laser_black_pixels = is_depth_meaningful(save_image=DEBUG_MODE, show_image=DEBUG_MODE)
has_depth, laser_black_pixels = is_depth_fill_rate_enough(save_image=DEBUG_MODE, show_image=DEBUG_MODE)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One successful frame is enough?

@remibettan remibettan Dec 9, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be checked later, as discussed

@OhadMeir
OhadMeir merged commit 8337979 into realsenseai:migration Dec 9, 2025
25 checks passed
@remibettan
remibettan deleted the test-depth-wall branch July 8, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants