Repository navigation
test-frames-depth modified to work in front of wall - #14497
Merged
Merged
Conversation
OhadMeir
reviewed
Dec 9, 2025
| fill_rate = 100.0 * (total - num_blank_pixels) / total if total > 0 else 0 | ||
| log.i(f"Depth fill rate: {fill_rate:.1f}% (blank pixels: {num_blank_pixels}/{total}), meaningful depth: {meaningful_depth} (largest bin: {max_nonzero_percent:.1f}% - max allowed {DEPTH_PERCENTAGE * 100:.1f}%)") | ||
| return meaningful_depth, num_blank_pixels | ||
| fill_rate_ok = fill_rate > (1 - BLACK_PIXEL_THRESHOLD) * 100.0 |
Contributor
There was a problem hiding this comment.
Will be OK if fill rate > 20%. Seems a bit low. I think should be at least 50
OhadMeir
reviewed
Dec 9, 2025
| # we check a few different frames to try and detect depth | ||
| for frame_num in range(FRAMES_TO_CHECK): | ||
| has_depth, laser_black_pixels = is_depth_meaningful(save_image=DEBUG_MODE, show_image=DEBUG_MODE) | ||
| has_depth, laser_black_pixels = is_depth_fill_rate_enough(save_image=DEBUG_MODE, show_image=DEBUG_MODE) |
Contributor
There was a problem hiding this comment.
One successful frame is enough?
Contributor
Author
There was a problem hiding this comment.
will be checked later, as discussed
OhadMeir
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.